Re: [dpdk-dev] [PATCH 1/7] net/mlx5: rename confusing object in probe code

2018-06-12 Thread Adrien Mazarguil
On Sun, Jun 10, 2018 at 11:00:57AM +, Xueming(Steven) Li wrote: > Ack except one minor question below. > > - mlx5_glue->dv_query_device(attr_ctx, &attrs_out); > > - if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED) { > > - if (attrs_out.flags & MLX5DV_CONTEXT_FLAGS_ENHANCED

Re: [dpdk-dev] [PATCH 1/7] net/mlx5: rename confusing object in probe code

2018-06-10 Thread Xueming(Steven) Li
Ack except one minor question below. > -Original Message- > From: dev On Behalf Of Adrien Mazarguil > Sent: Saturday, May 26, 2018 12:35 AM > To: Shahaf Shuler > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/7] net/mlx5: rename confusing object in probe > code &

[dpdk-dev] [PATCH 1/7] net/mlx5: rename confusing object in probe code

2018-05-25 Thread Adrien Mazarguil
There are several attribute objects in this function: - IB device attributes (struct ibv_device_attr_ex device_attr). - Direct Verbs attributes (struct mlx5dv_context attrs_out). - Port attributes (struct ibv_port_attr). - IB device attributes again (struct ibv_device_attr_ex device_attr_ex). "at