Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

2018-02-07 Thread Mcnamara, John
8 2:23 PM > >> To: Kovacevic, Marko > >> Cc: dev@dpdk.org; Maxime Coquelin ; > >> Yuanhan Liu ; Mcnamara, John > >> > >> Subject: Re: [dpdk-dev] [PATCH 1/8] vhost: add security model > >> documentation to vhost_user.c > >> > &g

Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

2018-02-07 Thread Maxime Coquelin
1/8] vhost: add security model documentation to vhost_user.c On Tue, Feb 06, 2018 at 01:26:13PM +, Kovacevic, Marko wrote: Input validation is not applied consistently in vhost_user.c. This suggests that not everyone has the same security model in mind when working on the code. Make the

Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

2018-02-07 Thread Mcnamara, John
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Tuesday, February 6, 2018 2:23 PM > To: Kovacevic, Marko > Cc: dev@dpdk.org; Maxime Coquelin ; Yuanhan > Liu ; Mcnamara, John > Subject: Re: [dpdk-dev] [PATCH 1/8] vhos

Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

2018-02-06 Thread Kovacevic, Marko
<...> > > This is a useful comment but I don't know if it makes sense to include it in > the vhost_user.c file. > > > > Particularly at the top where it looks like a general descriptive comment > > for > the file. > > > > It would probably be better in the vhost-user section of the programmer's >

Re: [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

2018-02-06 Thread Kovacevic, Marko
> Input validation is not applied consistently in vhost_user.c. This suggests > that > not everyone has the same security model in mind when working on the > code. > > Make the security model explicit so that everyone can understand and follow > the same model when modifying the code. > > Signe

[dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c

2018-02-05 Thread Stefan Hajnoczi
Input validation is not applied consistently in vhost_user.c. This suggests that not everyone has the same security model in mind when working on the code. Make the security model explicit so that everyone can understand and follow the same model when modifying the code. Signed-off-by: Stefan Ha