Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-18 Thread Xia, Chenbo
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Saturday, December 19, 2020 1:18 AM > To: Xia, Chenbo > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; Liang, > Cunming ; Lu, Xiuchun ; Li, > Miao ; Wu, Jingjing > Subject: Re: [PATCH 1/9] lib: introdu

Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-18 Thread Xia, Chenbo
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Saturday, December 19, 2020 1:14 AM > To: Xia, Chenbo > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; Liang, > Cunming ; Lu, Xiuchun ; Li, > Miao ; Wu, Jingjing > Subject: Re: [PATCH 1/9] lib: introdu

Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2020 15:38:43 +0800 Chenbo Xia wrote: > +typedef struct vfio_user_msg { > + uint16_t msg_id; > + uint16_t cmd; > + uint32_t size; > +#define VFIO_USER_TYPE_CMD (0x0) /* Message type is COMMAND */ > +#define VFIO_USER_TYPE_REPLY (0x1 << 0) /* Message typ

Re: [dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-18 Thread Stephen Hemminger
On Fri, 18 Dec 2020 15:38:43 +0800 Chenbo Xia wrote: > +inline void vfio_user_close_msg_fds(VFIO_USER_MSG *msg) > +{ > + int i; > + > + for (i = 0; i < msg->fd_num; i++) > + close(msg->fds[i]); > +} > + Please don't use non-static inlines.

[dpdk-dev] [PATCH 1/9] lib: introduce vfio-user library

2020-12-17 Thread Chenbo Xia
This patch introduces vfio-user library, which follows vfio-user protocol v1.0. As vfio-user has server and client implementaion, this patch introduces basic structures and internal functions that will be used by both server and client. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- MA