Re: [dpdk-dev] [PATCH 2/2] bitmap: deprecate and rename rte_bsf64

2018-11-22 Thread Thomas Monjalon
22/11/2018 18:04, Thomas Monjalon: > 21/11/2018 13:05, Anatoly Burakov: > > Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in > > that it prevents undefined behavior by checking if incoming > > parameter is zero) and move it to common header. > > > > Signed-off-by: Anatoly Burakov >

Re: [dpdk-dev] [PATCH 2/2] bitmap: deprecate and rename rte_bsf64

2018-11-22 Thread Thomas Monjalon
22/11/2018 19:56, Ananyev, Konstantin: > > Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in > > that it prevents undefined behavior by checking if incoming > > parameter is zero) and move it to common header. > > Probably a stupid one: why to rename? > Why just not fix rte_bsf64 to

Re: [dpdk-dev] [PATCH 2/2] bitmap: deprecate and rename rte_bsf64

2018-11-22 Thread Ananyev, Konstantin
> > Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in > that it prevents undefined behavior by checking if incoming > parameter is zero) and move it to common header. Probably a stupid one: why to rename? Why just not fix rte_bsf64 to make it work with zero value, and keep the sa

Re: [dpdk-dev] [PATCH 2/2] bitmap: deprecate and rename rte_bsf64

2018-11-22 Thread Thomas Monjalon
21/11/2018 13:05, Anatoly Burakov: > Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in > that it prevents undefined behavior by checking if incoming > parameter is zero) and move it to common header. > > Signed-off-by: Anatoly Burakov > Acked-by: Cristian Dumitrescu > Acked-by: Jas

[dpdk-dev] [PATCH 2/2] bitmap: deprecate and rename rte_bsf64

2018-11-21 Thread Anatoly Burakov
Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in that it prevents undefined behavior by checking if incoming parameter is zero) and move it to common header. Signed-off-by: Anatoly Burakov Acked-by: Cristian Dumitrescu Acked-by: Jasvinder Singh --- doc/guides/rel_notes/deprecati