Re: [dpdk-dev] [PATCH 2/2] dev: use rte_kvargs

2018-03-26 Thread Wiles, Keith
> On Mar 26, 2018, at 8:59 AM, Gaëtan Rivet wrote: > > Hi Neil, > > On Mon, Mar 26, 2018 at 07:38:19AM -0400, Neil Horman wrote: >> On Fri, Mar 23, 2018 at 07:45:03PM +0100, Gaetan Rivet wrote: >>> Signed-off-by: Gaetan Rivet >>> --- >>> >>> Cc: Neil Horman >>> > > Keep in mind that all o

Re: [dpdk-dev] [PATCH 2/2] dev: use rte_kvargs

2018-03-26 Thread Gaëtan Rivet
Hi Neil, On Mon, Mar 26, 2018 at 07:38:19AM -0400, Neil Horman wrote: > On Fri, Mar 23, 2018 at 07:45:03PM +0100, Gaetan Rivet wrote: > > Signed-off-by: Gaetan Rivet > > --- > > > > Cc: Neil Horman > > Keep in mind that all of this is to achieve the trivial task I was doing in 20 lines or so.

Re: [dpdk-dev] [PATCH 2/2] dev: use rte_kvargs

2018-03-26 Thread Neil Horman
On Fri, Mar 23, 2018 at 07:45:03PM +0100, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > > Cc: Neil Horman > I'm actually ok with this, but as Keith noted, I'm not sure why you didn't just: 1) Add the ability to create a grouping key, so that key value pairs could contain a list of

[dpdk-dev] [PATCH 2/2] dev: use rte_kvargs

2018-03-23 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- Cc: Neil Horman I find using rte_parse_kv cleaner. The function rte_dev_iterator_init is already ugly enough as it is. This is really not helping. lib/librte_eal/common/eal_common_dev.c | 127 + lib/librte_eal/linuxapp/eal/Makefi