Re: [dpdk-dev] [PATCH 2/2] doc: pass "werror" setting through to doc build

2020-01-17 Thread Aaron Conole
Bruce Richardson writes: > On Fri, Jan 17, 2020 at 08:34:01AM -0500, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > On Fri, Jan 17, 2020 at 08:16:55AM -0500, Aaron Conole wrote: >> >> Bruce Richardson writes: >> >> >> >> > When werror is set for the build, we should pass that flag th

Re: [dpdk-dev] [PATCH 2/2] doc: pass "werror" setting through to doc build

2020-01-17 Thread Bruce Richardson
On Fri, Jan 17, 2020 at 08:34:01AM -0500, Aaron Conole wrote: > Bruce Richardson writes: > > > On Fri, Jan 17, 2020 at 08:16:55AM -0500, Aaron Conole wrote: > >> Bruce Richardson writes: > >> > >> > When werror is set for the build, we should pass that flag through to > >> > sphinx so that it c

Re: [dpdk-dev] [PATCH 2/2] doc: pass "werror" setting through to doc build

2020-01-17 Thread Aaron Conole
Bruce Richardson writes: > On Fri, Jan 17, 2020 at 08:16:55AM -0500, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > When werror is set for the build, we should pass that flag through to >> > sphinx so that it can flag warnings as errors too. >> > >> > Signed-off-by: Bruce Richardson >

Re: [dpdk-dev] [PATCH 2/2] doc: pass "werror" setting through to doc build

2020-01-17 Thread Bruce Richardson
On Fri, Jan 17, 2020 at 08:16:55AM -0500, Aaron Conole wrote: > Bruce Richardson writes: > > > When werror is set for the build, we should pass that flag through to > > sphinx so that it can flag warnings as errors too. > > > > Signed-off-by: Bruce Richardson > > --- > > I see that this actuall

Re: [dpdk-dev] [PATCH 2/2] doc: pass "werror" setting through to doc build

2020-01-17 Thread Aaron Conole
Bruce Richardson writes: > When werror is set for the build, we should pass that flag through to > sphinx so that it can flag warnings as errors too. > > Signed-off-by: Bruce Richardson > --- I see that this actually works to generate the errors... BUT if we merge this it will break the build.

[dpdk-dev] [PATCH 2/2] doc: pass "werror" setting through to doc build

2020-01-17 Thread Bruce Richardson
When werror is set for the build, we should pass that flag through to sphinx so that it can flag warnings as errors too. Signed-off-by: Bruce Richardson --- buildtools/call-sphinx-build.py | 5 ++--- doc/guides/meson.build | 4 2 files changed, 6 insertions(+), 3 deletions(-) diff