Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-26 Thread Akhil Goyal
Hi Marius, > > Hi, > > About your comments: > > 1) I used macros around sa->flags where it was needed. Not all checks for that > set of flags use information if it is transport mode. As for macro > WITHOUT_TRANSPORT_VERSION, it was set only for checks that required > information from set of fla

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-25 Thread Drost, MariuszX
Hi, About your comments: 1) I used macros around sa->flags where it was needed. Not all checks for that set of flags use information if it is transport mode. As for macro WITHOUT_TRANSPORT_VERSION, it was set only for checks that required information from set of flags without taking into accou

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-25 Thread Akhil Goyal
Hi Marius, Could you please send the updated patch soon, so that they can be applied before RC1. Thanks, Akhil > > Hi Marius, > > > > Application ipsec-secgw is not working for IPv4 transport mode and for > > IPv6 both transport and tunnel mode. > > > > IPv6 tunnel mode is not working due to

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-20 Thread Akhil Goyal
Hi Marius, > Application ipsec-secgw is not working for IPv4 transport mode and for > IPv6 both transport and tunnel mode. > > IPv6 tunnel mode is not working due to wrongly assigned fields of > security association patterns, as it was IPv4, during creation of > inline crypto session. > > IPv6

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-06 Thread Ananyev, Konstantin
> -Original Message- > From: Drost, MariuszX > Sent: Tuesday, June 4, 2019 11:07 AM > To: Nicolau, Radu ; akhil.go...@nxp.com; Lu, Wenzhuo > ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Drost, MariuszX > Subject: [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes > >

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-04 Thread Mariusz Drost
Application ipsec-secgw is not working for IPv4 transport mode and for IPv6 both transport and tunnel mode. IPv6 tunnel mode is not working due to wrongly assigned fields of security association patterns, as it was IPv4, during creation of inline crypto session. IPv6 and IPv4 transport mode is it