Re: [dpdk-dev] [PATCH 2/2] net/af_xdp: make reserve/submit peek/release consistent

2019-04-15 Thread Ye Xiaolong
Hi, David Thanks for you detailed review comment. On 04/15, David Marchand wrote: >On Fri, Apr 12, 2019 at 4:54 PM Xiaolong Ye wrote: > >> As David pointed out, if we reserve N slots, but only submit n slots, >> we would end up with an incorrect opinion of the number of available slots >> later

Re: [dpdk-dev] [PATCH 2/2] net/af_xdp: make reserve/submit peek/release consistent

2019-04-15 Thread David Marchand
On Fri, Apr 12, 2019 at 4:54 PM Xiaolong Ye wrote: > As David pointed out, if we reserve N slots, but only submit n slots, > we would end up with an incorrect opinion of the number of available slots > later, we also would get wrong idx when we call xsk_ring_prod__reserve next > time. It also app

[dpdk-dev] [PATCH 2/2] net/af_xdp: make reserve/submit peek/release consistent

2019-04-12 Thread Xiaolong Ye
As David pointed out, if we reserve N slots, but only submit n slots, we would end up with an incorrect opinion of the number of available slots later, we also would get wrong idx when we call xsk_ring_prod__reserve next time. It also applies to xsk_ring_cons__peek()/xsk_ring_cons__release(). This