[dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD

2021-05-06 Thread David Marchand
Spotted by sparse in OVS build: ../../lib/netdev-dpdk.c: note: in included file (through /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h, /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h, ...): ../../include/sparse/arpa/inet.h:22:2: error: "Must include before for FreeBSD sup

Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD

2021-05-06 Thread Dmitry Kozlyuk
2021-05-06 17:14 (UTC+0200), David Marchand: > Spotted by sparse in OVS build: > ../../lib/netdev-dpdk.c: note: in included file (through > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h, > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h, ...): > ../../include/sparse/arpa/ine

Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD

2021-05-07 Thread David Marchand
On Fri, May 7, 2021 at 12:24 AM Dmitry Kozlyuk wrote: > > 2021-05-06 17:14 (UTC+0200), David Marchand: > > Spotted by sparse in OVS build: > > ../../lib/netdev-dpdk.c: note: in included file (through > > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h, > > /home/runner/work/ovs/ovs/dpdk-

Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD

2021-05-10 Thread David Marchand
Hello Ben, On Fri, May 7, 2021 at 9:13 PM Ben Pfaff wrote: > > > > It would be interesting to know exact issue this solves for OVS. > > > > Referenced commit only says FreeBSD "insists" on this include order, > > > > but DPDK and standalone files with these includes build either way. > > > > > >

Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD

2021-05-11 Thread Ben Pfaff
On Fri, May 07, 2021 at 11:06:38AM +0200, David Marchand wrote: > On Fri, May 7, 2021 at 12:24 AM Dmitry Kozlyuk > wrote: > > > > 2021-05-06 17:14 (UTC+0200), David Marchand: > > > Spotted by sparse in OVS build: > > > ../../lib/netdev-dpdk.c: note: in included file (through > > > /home/runner/wo

Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD

2021-05-11 Thread Ben Pfaff
On Fri, May 07, 2021 at 12:12:09PM -0700, Ben Pfaff wrote: > On Fri, May 07, 2021 at 11:06:38AM +0200, David Marchand wrote: > > On Fri, May 7, 2021 at 12:24 AM Dmitry Kozlyuk > > wrote: > > > > > > 2021-05-06 17:14 (UTC+0200), David Marchand: > > > > Spotted by sparse in OVS build: > > > > ../..

Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD

2021-05-11 Thread Olivier Matz
On Thu, May 06, 2021 at 05:14:26PM +0200, David Marchand wrote: > Spotted by sparse in OVS build: > ../../lib/netdev-dpdk.c: note: in included file (through > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h, > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h, ...): > ../../incl