[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-10-21 Thread Thomas Monjalon
2015-08-05 12:49, Vincent JARDIN: > > Use '--disable-hw-vlan-filter' in testpmd command line will allow it > > continue to work. > > You can have a try. > > Yes, but not using this flag should not imply to exit. > > > I am not sure which one is better when app configures one feature but fail

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-08-05 Thread Vincent JARDIN
> Use '--disable-hw-vlan-filter' in testpmd command line will allow it > continue to work. > You can have a try. Yes, but not using this flag should not imply to exit. > I am not sure which one is better when app configures one feature but fail to > negotiate it with host(which means has > no

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-08-05 Thread Ouyang, Changchun
Hi Vincent, > -Original Message- > From: Vincent JARDIN [mailto:vincent.jardin at 6wind.com] > Sent: Tuesday, August 4, 2015 8:52 PM > To: Thomas Monjalon; Ouyang, Changchun > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 2/2] virtio: allo

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-08-04 Thread Stephen Hemminger
wrote: > > Hi Vincent, > > > -Original Message- > > From: Vincent JARDIN [mailto:vincent.jardin at 6wind.com] > > Sent: Tuesday, August 4, 2015 8:52 PM > > To: Thomas Monjalon; Ouyang, Changchun > > Cc: dev at dpdk.org; Stephen Hemminger > >

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-08-04 Thread Vincent JARDIN
Thomas, Changchun, On 29/07/2015 14:56, Thomas Monjalon wrote: > Back on this old patch, it seems justified but nobody agreed. > > --- a/lib/librte_pmd_virtio/virtio_ethdev.c > +++ b/lib/librte_pmd_virtio/virtio_ethdev.c > @@ -1288,7 +1288,6 @@ virtio_dev_configure(struct rte_eth_dev *dev) >

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-07-30 Thread Ouyang, Changchun
I have comments for that. Pls see below. > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, July 29, 2015 8:57 PM > To: Ouyang, Changchun > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 2/2] vir

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-07-29 Thread Thomas Monjalon
Back on this old patch, it seems justified but nobody agreed. --- a/lib/librte_pmd_virtio/virtio_ethdev.c +++ b/lib/librte_pmd_virtio/virtio_ethdev.c @@ -1288,7 +1288,6 @@ virtio_dev_configure(struct rte_eth_dev *dev) && !vtpci_with_feature(hw, VIRTIO_NET_F_CTRL_VLAN)) {

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-03-06 Thread Stephen Hemminger
On Fri, 6 Mar 2015 03:39:47 + "Ouyang, Changchun" wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen > > Hemminger > > Sent: Friday, March 6, 2015 8:45 AM > > To: dev at dpdk.org >

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-03-06 Thread Ouyang, Changchun
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Friday, March 6, 2015 8:45 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering > > Vla

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-03-05 Thread Stephen Hemminger
Vlan filtering is an option, and not a requirement. If host does not support filtering then it can be done in software. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c