Re: [dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-30 Thread Thomas Monjalon
30/07/2020 11:56, yang_y...@163.com: > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -1193,7 +1193,7 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf > *mi, struct rte_mbuf *m) > RTE_ASSERT(m->shinfo != NULL); > > if (rte_mbuf_ext_refcnt_update(m->s

[dpdk-dev] [PATCH 2/3] mbuf: change free_cb interface to adapt to GSO case

2020-07-30 Thread yang_y_yi
From: Yi Yang In GSO case, segmented mbufs are attached to original mbuf which can't be freed when it is external. The issue is free_cb doesn't know original mbuf and doesn't free it when refcnt of shinfo is 0. Original mbuf can be freed by rte_pktmbuf_free segmented mbufs or by rte_pktmbuf_free