Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-18 Thread Ferruh Yigit
On 10/18/2021 12:13 PM, Dmitry Kozlyuk wrote: -Original Message- From: Ferruh Yigit Sent: 18 октября 2021 г. 11:42 To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko ; Ori Kam ; Raslan Darawsheh ; NBU-Contact-Thomas Monjalon Cc: Qi Zhang ; jer...@marvell.com; Maxime Coquelin Subject:

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-18 Thread Dmitry Kozlyuk
> -Original Message- > From: Ferruh Yigit > Sent: 18 октября 2021 г. 11:42 > To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko > ; Ori Kam ; Raslan > Darawsheh ; NBU-Contact-Thomas Monjalon > > Cc: Qi Zhang ; jer...@marvell.com; Maxime Coquelin > > Subject: Re: [PATCH 2/5] ethdev: add

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-18 Thread Ferruh Yigit
On 10/16/2021 9:32 PM, Dmitry Kozlyuk wrote: -Original Message- From: Ferruh Yigit Sent: 15 октября 2021 г. 19:27 To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko ; Ori Kam ; Raslan Darawsheh Cc: NBU-Contact-Thomas Monjalon ; Qi Zhang ; jer...@marvell.com; Maxime Coquelin Subject: R

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-16 Thread Dmitry Kozlyuk
> -Original Message- > From: Ferruh Yigit > Sent: 15 октября 2021 г. 19:27 > To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko > ; Ori Kam ; Raslan > Darawsheh > Cc: NBU-Contact-Thomas Monjalon ; Qi Zhang > ; jer...@marvell.com; Maxime Coquelin > > Subject: Re: [PATCH 2/5] ethdev: add

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-15 Thread Ferruh Yigit
On 10/15/2021 1:35 PM, Dmitry Kozlyuk wrote: -Original Message- From: Ferruh Yigit [...] Introducing UNKNOWN state seems wrong to me. What should an application do when it is reported? Now there's just no way to learn how the PMD behaves, but if it provides a response, it can't be "I do

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-15 Thread Dmitry Kozlyuk
> -Original Message- > From: Ferruh Yigit > [...] > > Introducing UNKNOWN state seems wrong to me. > > What should an application do when it is reported? > > Now there's just no way to learn how the PMD behaves, > > but if it provides a response, it can't be "I don't know what I do". > > >

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-15 Thread Ferruh Yigit
On 10/14/2021 10:45 PM, Dmitry Kozlyuk wrote: -Original Message- From: Ferruh Yigit Sent: 14 октября 2021 г. 16:47 To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko ; Ori Kam ; Raslan Darawsheh Cc: NBU-Contact-Thomas Monjalon ; Qi Zhang ; jer...@marvell.com; Maxime Coquelin Subject:

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-15 Thread Andrew Rybchenko
On 10/15/21 12:04 PM, Dmitry Kozlyuk wrote: >> [...] > From: Dmitry Kozlyuk > > rte_flow_action_handle_create() did not mention what happens with an > indirect action when a device is stopped, possibly reconfigured, and > started again. It is natural for some indirect actions t

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-15 Thread Dmitry Kozlyuk
> [...] > >>> From: Dmitry Kozlyuk > >>> > >>> rte_flow_action_handle_create() did not mention what happens with an > >>> indirect action when a device is stopped, possibly reconfigured, and > >>> started again. It is natural for some indirect actions to be > >>> persistent, like counters and mete

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-15 Thread Andrew Rybchenko
On 10/14/21 5:14 PM, Dmitry Kozlyuk wrote: > > >> -Original Message- >> From: Dmitry Kozlyuk >> Sent: 13 октября 2021 г. 11:33 >> To: dev@dpdk.org; Andrew Rybchenko ; Ori >> Kam ; Raslan Darawsheh >> Cc: NBU-Contact-Thomas Monjalon ; Ferruh Yigit >> >> Subject: RE: [PATCH 2/5] ethdev: a

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-14 Thread Dmitry Kozlyuk
> Introducing UNKNOWN state seems wrong to me. > What should an application do when it is reported? > Now there's just no way to learn how the PMD behaves, but if it provides a > response, it can't be "I don't know what I do". > > Here's what I understood from the code, assuming there are no bugs

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-14 Thread Dmitry Kozlyuk
> -Original Message- > From: Ferruh Yigit > Sent: 14 октября 2021 г. 16:47 > To: Dmitry Kozlyuk ; dev@dpdk.org; Andrew Rybchenko > ; Ori Kam ; Raslan > Darawsheh > Cc: NBU-Contact-Thomas Monjalon ; Qi Zhang > ; jer...@marvell.com; Maxime Coquelin > > Subject: Re: [PATCH 2/5] ethdev: add

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-14 Thread Ferruh Yigit
On 10/13/2021 9:32 AM, Dmitry Kozlyuk wrote: This thread continues discussions on previous versions to keep everything in the thread with final patches: [1]: http://inbox.dpdk.org/dev/d5673b58-5aa6-ca35-5b60-d938e56cf...@oktetlabs.ru/ [2]: http://inbox.dpdk.org/dev/dm8pr12mb5400997ccec9169ac5a

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-14 Thread Dmitry Kozlyuk
> -Original Message- > From: Dmitry Kozlyuk > Sent: 13 октября 2021 г. 11:33 > To: dev@dpdk.org; Andrew Rybchenko ; Ori > Kam ; Raslan Darawsheh > Cc: NBU-Contact-Thomas Monjalon ; Ferruh Yigit > > Subject: RE: [PATCH 2/5] ethdev: add capability to keep shared objects on > restart > >

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-13 Thread Dmitry Kozlyuk
This thread continues discussions on previous versions to keep everything in the thread with final patches: [1]: http://inbox.dpdk.org/dev/d5673b58-5aa6-ca35-5b60-d938e56cf...@oktetlabs.ru/ [2]: http://inbox.dpdk.org/dev/dm8pr12mb5400997ccec9169ac5ae0c89d6...@dm8pr12mb5400.namprd12.prod.outlook.

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-06 Thread Ori Kam
Hi Dmitry, > -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, October 5, 2021 3:52 AM > To: dev@dpdk.org > Cc: Dmitry Kozlyuk ; Ori Kam ; > NBU-Contact-Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > > Subject: [PATCH 2/5] ethdev: add capability to keep shared objects on

[dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-04 Thread dkozlyuk
From: Dmitry Kozlyuk rte_flow_action_handle_create() did not mention what happens with an indirect action when a device is stopped, possibly reconfigured, and started again. It is natural for some indirect actions to be persistent, like counters and meters; keeping others just saves application t