[dpdk-dev] [PATCH 2/6] net/bnxt: fix potential data race

[Stephen Hemminger]

The response from the firmware is accessed multiple times.
This is a potential TOCTOU error.

Reported-by: Christopher Ertl <christopher.e...@microsoft.com>
Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
---
 drivers/net/bnxt/bnxt_hwrm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index a9c9c7297cab..20e2f6a36713 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -3746,6 +3746,7 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)
 {
        struct hwrm_port_led_qcaps_output *resp = bp->hwrm_cmd_resp_addr;
        struct hwrm_port_led_qcaps_input req = {0};
+       uint8_t num_leds;
        int rc;
 
        if (BNXT_VF(bp))
@@ -3757,10 +3758,11 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)
 
        HWRM_CHECK_RESULT();
 
-       if (resp->num_leds > 0 && resp->num_leds < BNXT_MAX_LED) {
+       num_leds = resp->num_leds;
+       if (num_leds > 0 && num_leds < BNXT_MAX_LED) {
                unsigned int i;
 
-               bp->num_leds = resp->num_leds;
+               bp->num_leds = num_leds;
                memcpy(bp->leds, &resp->led0_id,
                        sizeof(bp->leds[0]) * bp->num_leds);
                for (i = 0; i < bp->num_leds; i++) {
-- 
2.20.1