Re: [dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

2018-08-29 Thread Burakov, Anatoly
On 29-Aug-18 1:35 PM, Bruce Richardson wrote: On Wed, Aug 29, 2018 at 12:56:16PM +0100, Anatoly Burakov wrote: Musl already has PAGE_SIZE defined, and our define clashed with it. Rename our define to SYS_PAGE_SIZE. Bugzilla ID: 36 Signed-off-by: Anatoly Burakov --- Would it not be easier to

Re: [dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

2018-08-29 Thread Bruce Richardson
On Wed, Aug 29, 2018 at 12:56:16PM +0100, Anatoly Burakov wrote: > Musl already has PAGE_SIZE defined, and our define clashed with it. > Rename our define to SYS_PAGE_SIZE. > > Bugzilla ID: 36 > > Signed-off-by: Anatoly Burakov > --- Would it not be easier to just do? #ifndef PAGE_SIZE #define

[dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility

2018-08-29 Thread Anatoly Burakov
Musl already has PAGE_SIZE defined, and our define clashed with it. Rename our define to SYS_PAGE_SIZE. Bugzilla ID: 36 Signed-off-by: Anatoly Burakov --- drivers/bus/pci/linux/pci_vfio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/pci/linux/pci_vfio.