Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-02 Thread Akhil Goyal
> > -- > > > > > +#include "otx2_ipsec_po.h" > > > > Why is it named like this? What is 'po' ? > > > > > > [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for > > > inline and one for lookaside. The one for inline is

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-02 Thread Anoob Joseph
Hi Akhil, > > -- > > > > +#include "otx2_ipsec_po.h" > > > Why is it named like this? What is 'po' ? > > > > [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for > > inline and one for lookaside. The one for inline

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-02 Thread Akhil Goyal
> > > +#include "otx2_ipsec_po.h" > > Why is it named like this? What is 'po' ? > > [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for inline > and one for lookaside. The one for inline is FP and the one for lookaside is > PO > (Protocol Offload). > Isn't it better to write "inli

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-02 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, July 2, 2020 2:17 AM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; Vamsi Krishna Attunuru ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH 2/

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-01 Thread Akhil Goyal
> Subject: [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions > > Signed-off-by: Vamsi Attunuru > Signed-off-by: Tejasree Kondoj > --- Please add appropriate description in all the patches. > drivers/crypto/octeontx2/otx2_cryptodev_sec.h | 52 > drivers/crypto/octe

[dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-06-23 Thread Tejasree Kondoj
Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.h | 52 drivers/crypto/octeontx2/otx2_ipsec_po.h | 119 ++ drivers/crypto/octeontx2/otx2_security.h | 2 + drivers/net/octeontx2/otx2_ethdev_sec.h