Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-07-04 Thread Jerin Jacob
On Mon, May 4, 2020 at 2:02 AM David Marchand wrote: > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. > > Signed-off-by: David Marchand > --- > app/test/test_trace_register.c| 1

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Wed, May 6, 2020 at 1:40 AM Thomas Monjalon wrote: > > 05/05/2020 19:28, Jerin Jacob: > > On Tue, May 5, 2020 at 10:50 PM Thomas Monjalon wrote: > > > 05/05/2020 19:09, Jerin Jacob: > > > > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob > > > > wrote: > > > > > On Tue, May 5, 2020 at 10:28 PM T

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 19:28, Jerin Jacob: > On Tue, May 5, 2020 at 10:50 PM Thomas Monjalon wrote: > > 05/05/2020 19:09, Jerin Jacob: > > > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon > > > > wrote: > > > > > 05/05/2020 18:46, Jerin Jacob: > >

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 10:50 PM Thomas Monjalon wrote: > > 05/05/2020 19:09, Jerin Jacob: > > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon > > > wrote: > > > > 05/05/2020 18:46, Jerin Jacob: > > > > > On Tue, May 5, 2020 at 9:58 PM Dav

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 19:09, Jerin Jacob: > On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon wrote: > > > 05/05/2020 18:46, Jerin Jacob: > > > > On Tue, May 5, 2020 at 9:58 PM David Marchand > > > > wrote: > > > > > On Tue, May 5, 2020 at 5:25 PM Jerin

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 10:38 PM Jerin Jacob wrote: > > On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon wrote: > > > > 05/05/2020 18:46, Jerin Jacob: > > > On Tue, May 5, 2020 at 9:58 PM David Marchand > > > wrote: > > > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob > > > > wrote: > > > > > On

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 10:28 PM Thomas Monjalon wrote: > > 05/05/2020 18:46, Jerin Jacob: > > On Tue, May 5, 2020 at 9:58 PM David Marchand > > wrote: > > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob > > > > wrote: > > > > > On Tue, Ma

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 18:46, Jerin Jacob: > On Tue, May 5, 2020 at 9:58 PM David Marchand > wrote: > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 5:06 PM David Marchand > > > > wrote: > > > > > On Tue, May 5, 2

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 9:58 PM David Marchand wrote: > > On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > > > > > On Tue, May 5, 2020 at 5:06 PM David Marchand > > > wrote: > > > > > > > > On Tue, May 5, 2020 at 12:13 PM Jerin Jaco

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread David Marchand
On Tue, May 5, 2020 at 5:25 PM Jerin Jacob wrote: > > On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > > > On Tue, May 5, 2020 at 5:06 PM David Marchand > > wrote: > > > > > > On Tue, May 5, 2020 at 12:13 PM Jerin Jacob wrote: > > > > > > Please share the data. > > > > > > > > > > Measure

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 5:56 PM Jerin Jacob wrote: > > On Tue, May 5, 2020 at 5:06 PM David Marchand > wrote: > > > > On Tue, May 5, 2020 at 12:13 PM Jerin Jacob wrote: > > > > > Please share the data. > > > > > > > > Measured time between first rte_trace_point_register and last one with > > > >

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 5:06 PM David Marchand wrote: > > On Tue, May 5, 2020 at 12:13 PM Jerin Jacob wrote: > > > > Please share the data. > > > > > > Measured time between first rte_trace_point_register and last one with > > > a simple patch: > > > > I will try to reproduce this, once we finaliz

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Olivier Matz
Hi, On Tue, May 05, 2020 at 04:16:02PM +0530, Jerin Jacob wrote: > On Tue, May 5, 2020 at 3:56 PM Thomas Monjalon wrote: > > > > 05/05/2020 12:12, Jerin Jacob: > > > On Tue, May 5, 2020 at 1:53 PM David Marchand > > > wrote: > > > > On Tue, May 5, 2020 at 9:33 AM Jerin Jacob > > > > wrote: >

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread David Marchand
On Tue, May 5, 2020 at 12:13 PM Jerin Jacob wrote: > > > Please share the data. > > > > Measured time between first rte_trace_point_register and last one with > > a simple patch: > > I will try to reproduce this, once we finalize on the above synergy > with rte_log. I took the time to provide mea

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 3:56 PM Thomas Monjalon wrote: > > 05/05/2020 12:12, Jerin Jacob: > > On Tue, May 5, 2020 at 1:53 PM David Marchand > > wrote: > > > On Tue, May 5, 2020 at 9:33 AM Jerin Jacob wrote: > > > > > > What the proposed patch here. > > > > > > # Making N constructors from one >

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 12:12, Jerin Jacob: > On Tue, May 5, 2020 at 1:53 PM David Marchand > wrote: > > On Tue, May 5, 2020 at 9:33 AM Jerin Jacob wrote: > > > > > What the proposed patch here. > > > > > # Making N constructors from one > > > > > # Grouping global variable and register function under a sing

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 1:53 PM David Marchand wrote: > > On Tue, May 5, 2020 at 9:33 AM Jerin Jacob wrote: > > > > What the proposed patch here. > > > > # Making N constructors from one > > > > # Grouping global variable and register function under a single Marco > > > > and making it as N constr

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread David Marchand
On Tue, May 5, 2020 at 9:33 AM Jerin Jacob wrote: > > > What the proposed patch here. > > > # Making N constructors from one > > > # Grouping global variable and register function under a single Marco > > > and making it as N constructors. > > > Why can we do the same logic for rte_log? > > > > rt

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 12:55 PM Thomas Monjalon wrote: > > 05/05/2020 09:17, Jerin Jacob: > > On Tue, May 5, 2020 at 12:31 PM Thomas Monjalon wrote: > > > 05/05/2020 05:43, Jerin Jacob: > > > > On Tue, May 5, 2020 at 3:01 AM Thomas Monjalon > > > > wrote: > > > > > 04/05/2020 19:54, Jerin Jacob

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 09:17, Jerin Jacob: > On Tue, May 5, 2020 at 12:31 PM Thomas Monjalon wrote: > > 05/05/2020 05:43, Jerin Jacob: > > > On Tue, May 5, 2020 at 3:01 AM Thomas Monjalon > > > wrote: > > > > 04/05/2020 19:54, Jerin Jacob: > > > > > On Mon, May 4, 2020 at 11:10 PM David Marchand > > > > > >

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Jerin Jacob
On Tue, May 5, 2020 at 12:31 PM Thomas Monjalon wrote: > > 05/05/2020 05:43, Jerin Jacob: > > On Tue, May 5, 2020 at 3:01 AM Thomas Monjalon wrote: > > > 04/05/2020 19:54, Jerin Jacob: > > > > On Mon, May 4, 2020 at 11:10 PM David Marchand > > > > > On Mon, May 4, 2020 at 7:19 PM Jerin Jacob >

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-05 Thread Thomas Monjalon
05/05/2020 05:43, Jerin Jacob: > On Tue, May 5, 2020 at 3:01 AM Thomas Monjalon wrote: > > 04/05/2020 19:54, Jerin Jacob: > > > On Mon, May 4, 2020 at 11:10 PM David Marchand > > > > On Mon, May 4, 2020 at 7:19 PM Jerin Jacob > > > > wrote: > > > > > On Mon, May 4, 2020 at 10:38 PM David Marchan

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Jerin Jacob
On Tue, May 5, 2020 at 3:01 AM Thomas Monjalon wrote: > > 04/05/2020 19:54, Jerin Jacob: > > On Mon, May 4, 2020 at 11:10 PM David Marchand > > > On Mon, May 4, 2020 at 7:19 PM Jerin Jacob wrote: > > > > On Mon, May 4, 2020 at 10:38 PM David Marchand > > > > > On Mon, May 4, 2020 at 4:39 PM Jerin

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Thomas Monjalon
04/05/2020 19:54, Jerin Jacob: > On Mon, May 4, 2020 at 11:10 PM David Marchand > > On Mon, May 4, 2020 at 7:19 PM Jerin Jacob wrote: > > > On Mon, May 4, 2020 at 10:38 PM David Marchand > > > > On Mon, May 4, 2020 at 4:39 PM Jerin Jacob > > > > wrote: > > > > > On Mon, May 4, 2020 at 7:34 PM Da

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Jerin Jacob
On Mon, May 4, 2020 at 11:10 PM David Marchand wrote: > > On Mon, May 4, 2020 at 7:19 PM Jerin Jacob wrote: > > > > On Mon, May 4, 2020 at 10:38 PM David Marchand > > wrote: > > > > > > On Mon, May 4, 2020 at 4:39 PM Jerin Jacob wrote: > > > > > > > > On Mon, May 4, 2020 at 7:34 PM David Marcha

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 7:19 PM Jerin Jacob wrote: > > On Mon, May 4, 2020 at 10:38 PM David Marchand > wrote: > > > > On Mon, May 4, 2020 at 4:39 PM Jerin Jacob wrote: > > > > > > On Mon, May 4, 2020 at 7:34 PM David Marchand > > > wrote: > > > > > > > > On Mon, May 4, 2020 at 4:47 AM Jerin Ja

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Jerin Jacob
On Mon, May 4, 2020 at 10:38 PM David Marchand wrote: > > On Mon, May 4, 2020 at 4:39 PM Jerin Jacob wrote: > > > > On Mon, May 4, 2020 at 7:34 PM David Marchand > > wrote: > > > > > > On Mon, May 4, 2020 at 4:47 AM Jerin Jacob wrote: > > > > > > > > On Mon, May 4, 2020 at 2:02 AM David Marcha

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 4:39 PM Jerin Jacob wrote: > > On Mon, May 4, 2020 at 7:34 PM David Marchand > wrote: > > > > On Mon, May 4, 2020 at 4:47 AM Jerin Jacob wrote: > > > > > > On Mon, May 4, 2020 at 2:02 AM David Marchand > > > wrote: > > > > > > > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_PO

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Jerin Jacob
On Mon, May 4, 2020 at 7:34 PM David Marchand wrote: > > On Mon, May 4, 2020 at 4:47 AM Jerin Jacob wrote: > > > > On Mon, May 4, 2020 at 2:02 AM David Marchand > > wrote: > > > > > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > > > Merge them and let RTE_TRACE_POIN

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread David Marchand
On Mon, May 4, 2020 at 4:47 AM Jerin Jacob wrote: > > On Mon, May 4, 2020 at 2:02 AM David Marchand > wrote: > > > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > > Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. > > > Initially, I thought of

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-04 Thread Thomas Monjalon
04/05/2020 04:46, Jerin Jacob: > On Mon, May 4, 2020 at 2:02 AM David Marchand > wrote: > > > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > > Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. > > > Initially, I thought of doing the same. But,

Re: [dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-03 Thread Jerin Jacob
On Mon, May 4, 2020 at 2:02 AM David Marchand wrote: > > RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. > Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. Initially, I thought of doing the same. But, later I realized that this largely grows the nu

[dpdk-dev] [PATCH 2/8] trace: simplify trace point registration

2020-05-03 Thread David Marchand
RTE_TRACE_POINT_DEFINE and RTE_TRACE_POINT_REGISTER must come in pairs. Merge them and let RTE_TRACE_POINT_REGISTER handle the constructor part. Signed-off-by: David Marchand --- app/test/test_trace_register.c| 12 +- doc/guides/prog_guide/trace_lib.rst | 12 +- lib/l