Re: [dpdk-dev] [PATCH 22/38] net/dpaa: add NXP DPAA PMD driver skeleton

2017-07-01 Thread Shreyansh Jain
On Thursday 29 June 2017 07:59 PM, Shreyansh Jain wrote: > Hello Ferruh, > [...] > >> >>> + >>> +if (rte_eal_process_type() == RTE_PROC_PRIMARY) >>> +rte_free(eth_dev->data->dev_private); >>> + >> >> no pmd uninit() ? Just to clarify, were you asking about uninit of the driver? Ther

Re: [dpdk-dev] [PATCH 22/38] net/dpaa: add NXP DPAA PMD driver skeleton

2017-06-29 Thread Shreyansh Jain
Hello Ferruh, I was almost wondering if this series has been forgotten. Thanks for the comprehensive review. My comments inline (and in some other mails): On Wednesday 28 June 2017 09:11 PM, Ferruh Yigit wrote: On 6/16/2017 6:40 AM, Shreyansh Jain wrote: A skeleton which would be called after

Re: [dpdk-dev] [PATCH 22/38] net/dpaa: add NXP DPAA PMD driver skeleton

2017-06-28 Thread Ferruh Yigit
On 6/16/2017 6:40 AM, Shreyansh Jain wrote: > A skeleton which would be called after bus device scan. It currently > fails to identify the device> > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > + > +/* Initialise a network interface */ > +static int dpaa_eth_dev_init(st

[dpdk-dev] [PATCH 22/38] net/dpaa: add NXP DPAA PMD driver skeleton

2017-06-15 Thread Shreyansh Jain
A skeleton which would be called after bus device scan. It currently fails to identify the device. Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- MAINTAINERS | 1 + drivers/net/dpaa/Makefile | 64 + drivers/net/dpaa/dpaa_