Hi Cristian,
In hindsight, I was overly agressive in proposing the same change
(approach #2, as you call it below) for rte_port_ring and rte_port_sched.
Changing local variable bsz_mask to uint64_t should be sufficient.
Please see additional comments inline below.
On 3/31/16 11:41 AM,
> -Original Message-
> From: Robert Sanford [mailto:rsanford2 at gmail.com]
> Sent: Monday, March 28, 2016 9:52 PM
> To: dev at dpdk.org; Dumitrescu, Cristian
> Subject: [PATCH 3/4] port: fix full burst checks in f_tx_bulk ops
>
> For several f_tx_bulk functions in
For several f_tx_bulk functions in rte_port_{ethdev,ring,sched}.c,
it appears that the intent of the bsz_mask logic is to test whether
pkts_mask contains a full burst (i.e., the least
significant bits are set).
There are two problems with the bsz_mask code: 1) It truncates
by using the wrong
3 matches
Mail list logo
