Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-14 Thread Thomas Monjalon
11/01/2019 20:50, Wiles, Keith: > > > On Jan 11, 2019, at 1:49 PM, Stephen Hemminger > > wrote: > > > > On Fri, 11 Jan 2019 19:37:00 + > > "Wiles, Keith" wrote: > > > >>> +/* make sure name is a possible Linux network device name */ > >>> +static bool is_valid_iface(const char *name) >

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Luse, Paul E
Thanks Jim!! -from my iPhone > On Jan 11, 2019, at 11:37 AM, Wiles, Keith wrote: > > > >> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger >> wrote: >> >> If interface name is passed to remote or iface then check >> the length and for invalid characters. This avoids problems where >> name

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 1:49 PM, Stephen Hemminger > wrote: > > On Fri, 11 Jan 2019 19:37:00 + > "Wiles, Keith" wrote: > >>> +/* make sure name is a possible Linux network device name */ >>> +static bool is_valid_iface(const char *name) >> >> I am sorry, but the function name must be o

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Stephen Hemminger
On Fri, 11 Jan 2019 19:37:00 + "Wiles, Keith" wrote: > > +/* make sure name is a possible Linux network device name */ > > +static bool is_valid_iface(const char *name) > > I am sorry, but the function name must be on the next line as per the style. > I know you do not like it, but that i

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Wiles, Keith
> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger > wrote: > > If interface name is passed to remote or iface then check > the length and for invalid characters. This avoids problems where > name gets truncated or rejected by kernel. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/

[dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

2019-01-11 Thread Stephen Hemminger
If interface name is passed to remote or iface then check the length and for invalid characters. This avoids problems where name gets truncated or rejected by kernel. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 37 +++ 1 file changed, 33 i