19/09/2017 09:33, Shahaf Shuler:
> Tuesday, September 19, 2017 12:09 AM, Thomas Monjalon:
> > >
> > > It would be simpler, however am not sure invalid port is the only error to
> > consider. Another possible error can be the PMD is not supporting this
> > function.
> > > On that case returning 0 is
Tuesday, September 19, 2017 12:09 AM, Thomas Monjalon:
> >
> > It would be simpler, however am not sure invalid port is the only error to
> consider. Another possible error can be the PMD is not supporting this
> function.
> > On that case returning 0 is not good enough. The application cannot know
18/09/2017 20:18, Shahaf Shuler:
> Monday, September 18, 2017 5:45 PM, Bruce Richardson:
> >
> > On Mon, Sep 18, 2017 at 02:27:25PM +, Shahaf Shuler wrote:
> > > Monday, September 18, 2017 2:38 PM, Bruce Richardson
> > > > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote:
> > >
Monday, September 18, 2017 5:45 PM, Bruce Richardson:
>
> On Mon, Sep 18, 2017 at 02:27:25PM +, Shahaf Shuler wrote:
> > Monday, September 18, 2017 2:38 PM, Bruce Richardson
> > > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote:
> > > > 18/09/2017 13:11, Ananyev, Konstantin:
>
On Mon, Sep 18, 2017 at 02:27:25PM +, Shahaf Shuler wrote:
> Monday, September 18, 2017 2:38 PM, Bruce Richardson
> > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote:
> > > 18/09/2017 13:11, Ananyev, Konstantin:
> > > > From: Richardson, Bruce
> > > > > >
> > > > > > I think we
18/09/2017 16:27, Shahaf Shuler:
> Monday, September 18, 2017 2:38 PM, Bruce Richardson
> > On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote:
> > > 18/09/2017 13:11, Ananyev, Konstantin:
> > > > From: Richardson, Bruce
> > > > > >
> > > > > > I think we all in favor to have a separat
Monday, September 18, 2017 2:38 PM, Bruce Richardson
> On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote:
> > 18/09/2017 13:11, Ananyev, Konstantin:
> > > From: Richardson, Bruce
> > > > >
> > > > > I think we all in favor to have a separate API here.
> > > > > Though from the discuss
On Mon, Sep 18, 2017 at 01:32:29PM +0200, Thomas Monjalon wrote:
> 18/09/2017 13:11, Ananyev, Konstantin:
> > From: Richardson, Bruce
> > > On Mon, Sep 18, 2017 at 11:57:03AM +0100, Ananyev, Konstantin wrote:
> > > > From: Richardson, Bruce
> > > > > On Thu, Sep 14, 2017 at 10:02:26AM +0200, Thomas
18/09/2017 13:11, Ananyev, Konstantin:
> From: Richardson, Bruce
> > On Mon, Sep 18, 2017 at 11:57:03AM +0100, Ananyev, Konstantin wrote:
> > > From: Richardson, Bruce
> > > > On Thu, Sep 14, 2017 at 10:02:26AM +0200, Thomas Monjalon wrote:
> > > > > 13/09/2017 23:42, Ananyev, Konstantin:
> > > > >
18/09/2017 13:04, Bruce Richardson:
> On Mon, Sep 18, 2017 at 11:57:03AM +0100, Ananyev, Konstantin wrote:
> > From: Richardson, Bruce
> > > On Thu, Sep 14, 2017 at 10:02:26AM +0200, Thomas Monjalon wrote:
> > > > 13/09/2017 23:42, Ananyev, Konstantin:
> > > > > From: Thomas Monjalon [mailto:tho...
njalon
> > > Cc: Ananyev, Konstantin ;
> > > step...@networkplumber.org; dev@dpdk.org; Shahaf Shuler
> > >
> > > Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the
> > > new offloads API
> > >
> > > On Thu, Sep 14
rkplumber.org; dev@dpdk.org; Shahaf Shuler
> >
> > Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new
> > offloads API
> >
> > On Thu, Sep 14, 2017 at 10:02:26AM +0200, Thomas Monjalon wrote:
> > > 13/09/2017 23:42, Ananyev, Konstantin
rkplumber.org; dev@dpdk.org; Shahaf Shuler
> >
> > Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new
> > offloads API
> >
> > On Thu, Sep 14, 2017 at 10:02:26AM +0200, Thomas Monjalon wrote:
> > > 13/09/2017 23:42, Ananyev, Konstantin
> -Original Message-
> From: Richardson, Bruce
> Sent: Monday, September 18, 2017 11:32 AM
> To: Thomas Monjalon
> Cc: Ananyev, Konstantin ;
> step...@networkplumber.org; dev@dpdk.org; Shahaf Shuler
>
> Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add he
On Thu, Sep 14, 2017 at 10:02:26AM +0200, Thomas Monjalon wrote:
> 13/09/2017 23:42, Ananyev, Konstantin:
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > 13/09/2017 14:56, Ananyev, Konstantin:
> > > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > > Konstantin, I would like you
13/09/2017 23:42, Ananyev, Konstantin:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > 13/09/2017 14:56, Ananyev, Konstantin:
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Konstantin, I would like your opinion about the proposal below.
> > It is about making on the fly confi
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, September 13, 2017 2:21 PM
> To: Ananyev, Konstantin ;
> step...@networkplumber.org
> Cc: dev@dpdk.org; Shahaf Shuler
> Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add h
13/09/2017 14:56, Ananyev, Konstantin:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > 13/09/2017 13:16, Shahaf Shuler:
> > > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon:
> > > > I still think we must streamline ethdev API instead of complexifying.
> > > > We should drop the bi
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Wednesday, September 13, 2017 1:42 PM
> To: dev@dpdk.org; Shahaf Shuler
> Cc: Ananyev, Konstantin ;
> step...@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add h
Wednesday, September 13, 2017 3:42 PM, Thomas MonjalonL
> 13/09/2017 13:16, Shahaf Shuler:
> > Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon:
> > > I still think we must streamline ethdev API instead of complexifying.
> > > We should drop the big "configure everything" and configure offlo
13/09/2017 13:16, Shahaf Shuler:
> Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon:
> > I still think we must streamline ethdev API instead of complexifying.
> > We should drop the big "configure everything" and configure offloads one by
> > one, and per queue (the finer grain).
>
> The is
Wednesday, September 13, 2017 12:28 PM, Thomas Monjalon:
> I still think we must streamline ethdev API instead of complexifying.
> We should drop the big "configure everything" and configure offloads one by
> one, and per queue (the finer grain).
The issue is, that there is some functionality whic
I still think we must streamline ethdev API instead of complexifying.
We should drop the big "configure everything" and configure offloads
one by one, and per queue (the finer grain).
More comments below
06/09/2017 11:33, Ananyev, Konstantin:
> From: Shahaf Shuler [mailto:shah...@mellanox.com]
>
> -Original Message-
> From: Shahaf Shuler [mailto:shah...@mellanox.com]
> Sent: Wednesday, September 6, 2017 7:02 AM
> To: Ananyev, Konstantin ; Thomas Monjalon
>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to th
Tuesday, September 5, 2017 6:31 PM, Ananyev, Konstantin:
> >
> > > > > > > In fact, right now it is possible to query/change these 3
> > > > > > > vlan offload flags on the fly (after dev_start) on port
> > > > > > > basis by
> > > rte_eth_dev_(get|set)_vlan_offload API.
> >
> > Regarding this API
>
> > > > > > In fact, right now it is possible to query/change these 3 vlan
> > > > > > offload flags on the fly (after dev_start) on port basis by
> > rte_eth_dev_(get|set)_vlan_offload API.
>
> Regarding this API from ethdev.
>
> So this seems like a hack on ethdev. Currently there are 2
05/09/2017 12:51, Shahaf Shuler:
> So looks like we all agree PMDs should report as part of the
> rte_eth_dev_info_get which offloads are per port and which are per queue.
>
> Regarding the offloads configuration by application I see 2 options:
> 1. have an API to set offloads per port as part of
Tuesday, September 5, 2017 11:10 AM, Ananyev, Konstantin:
> > > > > In fact, right now it is possible to query/change these 3 vlan
> > > > > offload flags on the fly (after dev_start) on port basis by
> rte_eth_dev_(get|set)_vlan_offload API.
Regarding this API from ethdev.
So this seems like a
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Tuesday, September 5, 2017 8:48 AM
> To: Ananyev, Konstantin
> Cc: Shahaf Shuler ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new
> offload
04/09/2017 16:18, Ananyev, Konstantin:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > 04/09/2017 15:25, Ananyev, Konstantin:
> > > Hi Shahaf,
> > >
> > > > +/**
> > > > + * A conversion function from rxmode offloads API to rte_eth_rxq_conf
> > > > + * offloads API.
> > > > + */
> > > > +s
> -Original Message-
> From: Shahaf Shuler [mailto:shah...@mellanox.com]
> Sent: Monday, September 4, 2017 3:03 PM
> To: Ananyev, Konstantin ; Thomas Monjalon
>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new
&
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, September 4, 2017 2:54 PM
> To: Ananyev, Konstantin
> Cc: Shahaf Shuler ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new
> offload
Hi Konstantin,
Monday, September 4, 2017 4:25 PM, Ananyev, Konstantin:
>
> Hi Shahaf,
>
> > }
> >
> > +/**
> > + * A conversion function from rxmode offloads API to rte_eth_rxq_conf
> > + * offloads API.
> > + */
> > +static void
> > +rte_eth_convert_rxmode_offloads(struct rte_eth_rxmode *rxmod
04/09/2017 15:25, Ananyev, Konstantin:
> Hi Shahaf,
>
> > +/**
> > + * A conversion function from rxmode offloads API to rte_eth_rxq_conf
> > + * offloads API.
> > + */
> > +static void
> > +rte_eth_convert_rxmode_offloads(struct rte_eth_rxmode *rxmode,
> > + struct rte_e
Hi Shahaf,
> }
>
> +/**
> + * A conversion function from rxmode offloads API to rte_eth_rxq_conf
> + * offloads API.
> + */
> +static void
> +rte_eth_convert_rxmode_offloads(struct rte_eth_rxmode *rxmode,
> + struct rte_eth_rxq_conf *rxq_conf)
> +{
> + if (rxmode-
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Monday, September 4, 2017 8:12 AM
> To: tho...@monjalon.net
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new
> offloads AP
A new offloads API was introduced by commits:
commit 121fff673172 ("ethdev: introduce Rx queue offloads API")
commit 35ac80d92f29 ("ethdev: introduce Tx queue offloads API")
In order to enable the PMDs to support only one of the APIs,
a conversion functions from the old to new API were added.
Si
37 matches
Mail list logo
