[dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big

2016-04-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Sanford, Robert [mailto:rsanford at akamai.com] > Sent: Monday, April 11, 2016 9:37 PM > To: Dumitrescu, Cristian ; dev at dpdk.org > Cc: Liang, Cunming ; Venkatesan, Venky > ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH 4/4]

[dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big

2016-04-11 Thread Sanford, Robert
Hi Cristian, Yes, I mostly agree with your suggestions: 1. We should fix the two obvious bugs (1a and 1b) right away. Jasvinder's patches look fine. 2. We should take no immediate action on the issue I raised about PMDs (vector IXGBE) not enqueuing more than 32 packets. We can discuss and debate;

[dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big

2016-04-11 Thread Dumitrescu, Cristian
nal Message- > From: Sanford, Robert [mailto:rsanford at akamai.com] > Sent: Friday, April 1, 2016 5:22 PM > To: Dumitrescu, Cristian ; dev at dpdk.org > Cc: Liang, Cunming > Subject: Re: [dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big > > Hi Cristian, > >

[dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big

2016-04-01 Thread Sanford, Robert
Hi Cristian, Please see my comments inline. > > >> -Original Message- >> From: Robert Sanford [mailto:rsanford2 at gmail.com] >> Sent: Monday, March 28, 2016 9:52 PM >> To: dev at dpdk.org; Dumitrescu, Cristian >> Subject: [PATCH 4/4] port: fix ethdev writer burst too big >> >> For

[dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big

2016-03-31 Thread Dumitrescu, Cristian
> -Original Message- > From: Robert Sanford [mailto:rsanford2 at gmail.com] > Sent: Monday, March 28, 2016 9:52 PM > To: dev at dpdk.org; Dumitrescu, Cristian > Subject: [PATCH 4/4] port: fix ethdev writer burst too big > > For f_tx_bulk functions in rte_port_ethdev.c, we may

[dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big

2016-03-28 Thread Robert Sanford
For f_tx_bulk functions in rte_port_ethdev.c, we may unintentionally send bursts larger than tx_burst_sz to the underlying ethdev. Some PMDs (e.g., ixgbe) may truncate this request to their maximum burst size, resulting in unnecessary enqueuing failures or ethdev writer retries. We propose to fix