[dpdk-dev] [PATCH 4/6] qede: add driver common module

2016-02-23 Thread Harish Patil
> >On Sat, 20 Feb 2016 07:58:31 -0800 > wrote: > >> +unsigned long log2_align(unsigned long n) >> +{ > >Common code is good, but you need to practice good function name >hygiene on public functions to avoid any namespace clashes when >using static linking. > >The application might define a function

[dpdk-dev] [PATCH 4/6] qede: add driver common module

2016-02-20 Thread Stephen Hemminger
On Sat, 20 Feb 2016 07:58:31 -0800 wrote: > +unsigned long log2_align(unsigned long n) > +{ Common code is good, but you need to practice good function name hygiene on public functions to avoid any namespace clashes when using static linking. The application might define a function with log2_al

[dpdk-dev] [PATCH 4/6] qede: add driver common module

2016-02-20 Thread harish.pa...@qlogic.com
From: Harish Patil Signed-off-by: Harish Patil Signed-off-by: Rasesh Mody Signed-off-by: Sony Chacko --- drivers/net/qede/ecore/bcm_osal.c| 130 + drivers/net/qede/ecore/bcm_osal.h| 408 + drivers/net/qede/ecore/common_hsi.h | 714 ++ drivers/net/qede/ec