[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-06-13 Thread Michael S. Tsirkin
On Mon, May 09, 2016 at 11:22:04AM -0700, Yuanhan Liu wrote: > On Mon, May 09, 2016 at 04:25:38PM +, Xie, Huawei wrote: > > On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > > > However, Michael claims some concerns: he made a good point: a crash > > > is happening means some memory is corrupted, and i

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-05-10 Thread Xie, Huawei
On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > When DPDK app crashes (or quits, or gets killed), and when QEMU supports > reconnecting (patches have been sent, not merged yet), a restart of DPDK > app would get stale vring base from QEMU. That would break the kernel > virtio net completely, making it no

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-05-09 Thread Xie, Huawei
On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > However, Michael claims some concerns: he made a good point: a crash > is happening means some memory is corrupted, and it could be the virtio > memory being corrupted. In such case, nothing will work without the > reset. I don't get this point. What is th

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-05-09 Thread Michael S. Tsirkin
On Fri, May 06, 2016 at 11:40:22PM -0700, Yuanhan Liu wrote: > When DPDK app crashes (or quits, or gets killed), and when QEMU supports > reconnecting (patches have been sent, not merged yet), a restart of DPDK > app would get stale vring base from QEMU. That would break the kernel > virtio net com

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-05-09 Thread Xie, Huawei
On 5/9/2016 6:45 PM, Victor Kaplansky wrote: >> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c >> > index c88aaa3..df103aa 100644 >> > --- a/lib/librte_vhost/virtio-net.c >> > +++ b/lib/librte_vhost/virtio-net.c >> > @@ -560,6 +560,14 @@ vhost_set_vring_addr(int vid, str

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-05-09 Thread Yuanhan Liu
On Mon, May 09, 2016 at 01:39:25PM +, Xie, Huawei wrote: > On 5/9/2016 6:45 PM, Victor Kaplansky wrote: > >> diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c > >> > index c88aaa3..df103aa 100644 > >> > --- a/lib/librte_vhost/virtio-net.c > >> > +++ b/lib/librte_vhost/v

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-05-09 Thread Yuanhan Liu
On Mon, May 09, 2016 at 04:25:38PM +, Xie, Huawei wrote: > On 5/7/2016 2:36 PM, Yuanhan Liu wrote: > > However, Michael claims some concerns: he made a good point: a crash > > is happening means some memory is corrupted, and it could be the virtio > > memory being corrupted. In such case, nothi

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-05-09 Thread Victor Kaplansky
- Original Message - > From: "Yuanhan Liu" > To: dev at dpdk.org > Cc: "huawei xie" , "Yuanhan Liu" linux.intel.com>, "Michael S. Tsirkin" > > Sent: Saturday, May 7, 2016 9:40:22 AM > Subject: [dpdk-dev] [PATCH 4/6] vhos

[dpdk-dev] [PATCH 4/6] vhost: workaround stale vring base

2016-05-06 Thread Yuanhan Liu
When DPDK app crashes (or quits, or gets killed), and when QEMU supports reconnecting (patches have been sent, not merged yet), a restart of DPDK app would get stale vring base from QEMU. That would break the kernel virtio net completely, making it non-work any more, unless a driver reset is done.