[dpdk-dev] [PATCH 5/6] ether: allow setting mac address

2014-05-21 Thread Ivan Boule
Hi Stephen, Looking more precisely to your patch, I think that your requirement can beaddressed without adding a new `mac_addr_set` function into the [already overloaded] set of operations exported by a PMD. In fact, changing the default MAC address used by a port consists in executingthe foll

[dpdk-dev] [PATCH 5/6] ether: allow setting mac address

2014-05-15 Thread Ivan Boule
Hi Stephen, By default, changing the [current] default MAC address of a device is not equivalent to adding a MAC address to it ! At least, the minimum to do should consist in: 1. checking that the PMD exports both mac_addr_remove() and mac_addr_add() functions, returning a NON_SUPPORTED error c

[dpdk-dev] [PATCH 5/6] ether: allow setting mac address

2014-05-14 Thread Stephen Hemminger
Allow setting the default Ethernet address used on device. The underlying drivers allow it but the DPDK was blocking any attempts to change Ethernet address on device. For most devices, this is just the same as filling in address in mac address table entry 0, but for some devices this requires spe