[dpdk-dev] [PATCH 5/7] examples/qos_sched: enhance getopt_long usage

2020-11-24 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: st

Re: [dpdk-dev] [PATCH 5/7] examples/qos_sched: enhance getopt_long usage

2020-11-16 Thread Ibtisam Tariq
Yes, I will remove str_is function and submit the v3 of this patch soon. On Sat, Nov 14, 2020 at 4:13 PM David Marchand wrote: > On Wed, Nov 11, 2020 at 9:17 AM Ibtisam Tariq > wrote: > > > > Instead of using getopt_long return value, strcmp was used to > > compare the input parameters with the

Re: [dpdk-dev] [PATCH 5/7] examples/qos_sched: enhance getopt_long usage

2020-11-14 Thread David Marchand
On Wed, Nov 11, 2020 at 9:17 AM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve reada

[dpdk-dev] [PATCH 5/7] examples/qos_sched: enhance getopt_long usage

2020-11-11 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: st