[dpdk-dev] [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs

2015-02-11 Thread Yong Wang
On 12/16/14, 9:13 PM, "Stephen Hemminger" wrote: >From: Stephen Hemminger > >By defining macro as a stub it is possible to get rid of #ifdef's >in the actual code. > >Signed-off-by: Stephen Hemminger >--- > lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 6 -- >

[dpdk-dev] [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs

2015-02-10 Thread Stephen Hemminger
On Wed, 11 Feb 2015 00:54:57 + Yong Wang wrote: > Why not > #define VMXNET_ASSERT(x) do { (void)(0); } while (0) > > or simply > #define VMXNET_ASSERT(x) Because that will generate unused warnings in Gcc, and by having the compiler evaluate the result it also makes sure that junk doesn't

[dpdk-dev] [PATCH 5/7] vmxnet3: get rid of DEBUG ifdefs

2014-12-16 Thread Stephen Hemminger
From: Stephen Hemminger By defining macro as a stub it is possible to get rid of #ifdef's in the actual code. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 6 -- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 9 + 2 files changed,