Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-09 Thread Thomas Monjalon
10/03/2021 02:48, oulijun: > Can we add an API such as rte_eth_get_device(pord_id) > > for example: > struct rte_eth_dev * > rte_eth_get_device(uint16_t port_id) > { > return &rte_eth_devices[port_id]; > } An application is not supposed to access the struct rte_eth_dev. Which info do you

Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-09 Thread oulijun
在 2021/3/9 17:53, Ferruh Yigit 写道: On 3/9/2021 8:49 AM, oulijun wrote: 在 2021/3/9 1:33, Ferruh Yigit 写道: On 3/5/2021 9:57 AM, Lijun Ou wrote: From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Users must make sure there

Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-09 Thread Ferruh Yigit
On 3/9/2021 2:00 PM, Aaron Conole wrote: Ferruh Yigit writes: On 3/9/2021 8:49 AM, oulijun wrote: 在 2021/3/9 1:33, Ferruh Yigit 写道: On 3/5/2021 9:57 AM, Lijun Ou wrote: From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt)

Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-09 Thread Aaron Conole
Ferruh Yigit writes: > On 3/9/2021 8:49 AM, oulijun wrote: >> >> >> 在 2021/3/9 1:33, Ferruh Yigit 写道: >>> On 3/5/2021 9:57 AM, Lijun Ou wrote: From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Users

Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-09 Thread Andrew Rybchenko
On 3/9/21 12:57 PM, Thomas Monjalon wrote: > 09/03/2021 10:53, Ferruh Yigit: >> On 3/9/2021 8:49 AM, oulijun wrote: >>> 2021/3/9 1:33, Ferruh Yigit: Similar to above comment 'rte_eth_devices' is the internal variable, applications should not access it directly. >>> No API is availab

Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-09 Thread Thomas Monjalon
09/03/2021 10:53, Ferruh Yigit: > On 3/9/2021 8:49 AM, oulijun wrote: > > 2021/3/9 1:33, Ferruh Yigit: > >> Similar to above comment 'rte_eth_devices' is the internal variable, > >> applications should not access it directly. > >> > > No API is available, and multiple references exist in the testp

Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-09 Thread Ferruh Yigit
On 3/9/2021 8:49 AM, oulijun wrote: 在 2021/3/9 1:33, Ferruh Yigit 写道: On 3/5/2021 9:57 AM, Lijun Ou wrote: From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Users must make sure there are no concurrent access to the same Tx

Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-09 Thread oulijun
在 2021/3/9 1:33, Ferruh Yigit 写道: On 3/5/2021 9:57 AM, Lijun Ou wrote: From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Users must make sure there are no concurrent access to the same Tx queue (like rte_eth_tx_burst, rte_e

Re: [dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-08 Thread Ferruh Yigit
On 3/5/2021 9:57 AM, Lijun Ou wrote: From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Users must make sure there are no concurrent access to the same Tx queue (like rte_eth_tx_burst, rte_eth_dev_tx_queue_stop and so on) this c

[dpdk-dev] [PATCH V2] app/testpmd: support Tx mbuf free on demand cmd

2021-03-05 Thread Lijun Ou
From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Users must make sure there are no concurrent access to the same Tx queue (like rte_eth_tx_burst, rte_eth_dev_tx_queue_stop and so on) this command executed. Signed-off-by: Chengw