Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-05 Thread Guo, Jia
On 7/4/2018 3:06 PM, Matan Azrad wrote: Hi Thomas, Guo From: Thomas Monjalon 03/07/2018 11:35, Guo, Jia: On 7/1/2018 3:46 PM, Matan Azrad wrote: From: Jeff Guo --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-04 Thread Matan Azrad
Hi Thomas, Guo From: Thomas Monjalon > 03/07/2018 11:35, Guo, Jia: > > On 7/1/2018 3:46 PM, Matan Azrad wrote: > > > From: Jeff Guo > > >> --- a/app/test-pmd/testpmd.c > > >> +++ b/app/test-pmd/testpmd.c > > >> @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char > *device_name, > > >> enum rte_dev_

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-03 Thread Guo, Jia
hi, thomas On 7/4/2018 6:44 AM, Thomas Monjalon wrote: 03/07/2018 11:35, Guo, Jia: On 7/1/2018 3:46 PM, Matan Azrad wrote: From: Jeff Guo --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum rte_dev_event_type type,

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-03 Thread Thomas Monjalon
03/07/2018 11:35, Guo, Jia: > On 7/1/2018 3:46 PM, Matan Azrad wrote: > > From: Jeff Guo > >> --- a/app/test-pmd/testpmd.c > >> +++ b/app/test-pmd/testpmd.c > >> @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum > >> rte_dev_event_type type, > >>case RTE_DEV_EVENT_REMOVE: >

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-03 Thread Guo, Jia
mantan, On 7/1/2018 3:46 PM, Matan Azrad wrote: Hi Jeff A good advance, thank you, but as I said in previous version, this patch inserts a bug and the next one fixes it. Patch 9 should be before patch 8 while this patch just add 1 more option for EAL hotplug. i agree that patch 9 before pa

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-01 Thread Matan Azrad
Hi Jeff A good advance, thank you, but as I said in previous version, this patch inserts a bug and the next one fixes it. Patch 9 should be before patch 8 while this patch just add 1 more option for EAL hotplug. Please see 1 more comment below. From: Jeff Guo > Use testpmd for example, to show

[dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-06-29 Thread Jeff Guo
Use testpmd for example, to show how an application smoothly handle failure when device being hot unplug. If app have enabled the device event monitor and register the hot plug event’s callback before running, once app detect the removal event, the callback would be called. It will first stop the p

[dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-06-29 Thread Jeff Guo
Use testpmd for example, to show how an application smoothly handle failure when device being hot unplug. If app have enabled the device event monitor and register the hot plug event’s callback before running, once app detect the removal event, the callback would be called. It will first stop the p