Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-15 Thread Ferruh Yigit
On 3/15/2018 6:16 AM, Shahaf Shuler wrote: > Thursday, March 15, 2018 12:41 AM, Ferruh Yigit: >> On 3/14/2018 5:49 AM, Shahaf Shuler wrote: >>> Tuesday, March 13, 2018 1:57 PM, Ferruh Yigit: > > Again - the application should follow the API which currently > dictates how to set por

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-14 Thread Shahaf Shuler
Thursday, March 15, 2018 12:41 AM, Ferruh Yigit: > On 3/14/2018 5:49 AM, Shahaf Shuler wrote: > > Tuesday, March 13, 2018 1:57 PM, Ferruh Yigit: > >>> > >>> Again - the application should follow the API which currently > >>> dictates how > >> to set port offload. It is not depends on the rx_queue_o

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 5:49 AM, Shahaf Shuler wrote: > Tuesday, March 13, 2018 1:57 PM, Ferruh Yigit: >>> >>> Again - the application should follow the API which currently dictates how >> to set port offload. It is not depends on the rx_queue_offloads capabilities. >>> For example, PMD which don't support qu

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-13 Thread Shahaf Shuler
Tuesday, March 13, 2018 1:57 PM, Ferruh Yigit: > > > > Again - the application should follow the API which currently dictates how > to set port offload. It is not depends on the rx_queue_offloads capabilities. > > For example, PMD which don't support queue offloads can still have > verification for

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-13 Thread Ferruh Yigit
On 3/13/2018 7:08 AM, Shahaf Shuler wrote: > Monday, March 12, 2018 9:05 PM, Ferruh Yigit: >> On 3/12/2018 5:58 PM, Shahaf Shuler wrote: >>> Monday, March 12, 2018 7:00 PM, Ferruh Yigit: There are some devices supports queue level offloads and there are some devices supports port level of

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-13 Thread Shahaf Shuler
Monday, March 12, 2018 9:05 PM, Ferruh Yigit: > On 3/12/2018 5:58 PM, Shahaf Shuler wrote: > > Monday, March 12, 2018 7:00 PM, Ferruh Yigit: > >> There are some devices supports queue level offloads and there are > >> some devices supports port level offloads. > >> > >> Values queue offload = 0x0 a

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-12 Thread Ferruh Yigit
On 3/12/2018 5:58 PM, Shahaf Shuler wrote: > Monday, March 12, 2018 7:00 PM, Ferruh Yigit: >> There are some devices supports queue level offloads and there are some >> devices supports port level offloads. >> >> Values queue offload = 0x0 and port offload = 0x1000, for the device that >> support q

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-12 Thread Shahaf Shuler
Monday, March 12, 2018 7:00 PM, Ferruh Yigit: > There are some devices supports queue level offloads and there are some > devices supports port level offloads. > > Values queue offload = 0x0 and port offload = 0x1000, for the device that > support queue level offloads may mean disabling all offloa

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-12 Thread Ferruh Yigit
@6wind.com >> Cc: dev@dpdk.org; Shahaf Shuler >> Subject: Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API >> >> On 1/17/2018 2:04 PM, Moti Haimovsky wrote: >>> Ethdev Rx offloads API has changed since: >>> commit ce17eddefc20 ("ethdev

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-12 Thread Shahaf Shuler
--Shahaf > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, March 2, 2018 11:44 PM > To: Mordechay Haimovsky ; > pascal.ma...@6wind.com > Cc: dev@dpdk.org; Shahaf Shuler > Subject: Re: [dpdk-dev] [PATCH V5 2/2

Re: [dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-03-02 Thread Ferruh Yigit
On 1/17/2018 2:04 PM, Moti Haimovsky wrote: > Ethdev Rx offloads API has changed since: > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > This commit adds support for the new Rx offloads API. > > Signed-off-by: Moti Haimovsky <...> > +static bool > +tap_rxq_are_offloads_valid(

[dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-01-17 Thread Moti Haimovsky
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit adds support for the new Rx offloads API. Signed-off-by: Moti Haimovsky --- V5: * Fixed compilation errors caused by not using PRIx64 in log messages when displaying uint64_t va