Re: [dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-24 Thread Remy Horton
On 24/01/2017 10:49, Thomas Monjalon wrote: [..] Seems OK to me, assuming Yuanhan's patch is going in as-is. Yuanhan's patch is already part of RC1. Ah ok. I'll rebase a v2 then..

Re: [dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-24 Thread Thomas Monjalon
2017-01-24 08:16, Remy Horton: > > On 20/01/2017 18:37, Thomas Monjalon wrote: > [..] > > 3 comments here: > > - it is in the wrong section (EAL instead of Drivers) > > - secondary processes can setup a vdev PMD > > - before Yuanhan's patch, even PCI PMD were blanking primary process data > > Sin

Re: [dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-24 Thread Remy Horton
On 20/01/2017 18:37, Thomas Monjalon wrote: [..] 3 comments here: - it is in the wrong section (EAL instead of Drivers) - secondary processes can setup a vdev PMD - before Yuanhan's patch, even PCI PMD were blanking primary process data Since the code being changed is in rte_ether rather than

Re: [dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-20 Thread Thomas Monjalon
2017-01-11 02:42, Remy Horton: > +* **ethdev: Fixed crash with multi-processing.** > + > + Even though only primary processes should setup PMDs, secondary > + processes were also blanket zeroing ethernet device memory. The > + result was NULL dereference crashes in multi-process setups. > + 3 c

Re: [dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-11 Thread Remy Horton
On 11/01/2017 14:22, Thomas Monjalon wrote: 2017-01-11 02:42, Remy Horton: Even though only primary processes should setup PMDs, secondary processes were also blanket zeroing ethernet device memory. The result was NULL dereference crashes in multi-process setups. Fixes: 7f95f78a8aea ("ethdev: c

Re: [dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-11 Thread Thomas Monjalon
2017-01-11 02:42, Remy Horton: > Even though only primary processes should setup PMDs, secondary > processes were also blanket zeroing ethernet device memory. The > result was NULL dereference crashes in multi-process setups. > > Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") I

[dpdk-dev] [PATCH v1] ethdev: fix multi-process NULL dereference crashes

2017-01-10 Thread Remy Horton
Even though only primary processes should setup PMDs, secondary processes were also blanket zeroing ethernet device memory. The result was NULL dereference crashes in multi-process setups. Fixes: 7f95f78a8aea ("ethdev: clear data when allocating device") Signed-off-by: Remy Horton --- doc/guide