[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-13 Thread Avi Kivity
islav Zolotarov; didier.pallard > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598 > > > > On 09/13/2015 02:47 PM, Ananyev, Konstantin wrote: > > > > > >> -Original Message- >

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-13 Thread Ananyev, Konstantin
, 2015 6:48 PM > >> To: Thomas Monjalon; Vladislav Zolotarov; didier.pallard > >> Cc: dev at dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 > >> for all NICs but 82598 > >> > >> On 09/11/2015 07:08 PM, T

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-13 Thread Avi Kivity
c: dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 >> for all NICs but 82598 >> >> On 09/11/2015 07:08 PM, Thomas Monjalon wrote: >>> 2015-09-11 18:43, Avi Kivity: >>>> On 09/11/2015 06:12

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-13 Thread Vlad Zolotarov
at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 >> for all NICs but 82598 >> >> On 09/11/2015 07:08 PM, Thomas Monjalon wrote: >>> 2015-09-11 18:43, Avi Kivity: >>>> On 09/11/2015 06:12

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Avi Kivity > Sent: Friday, September 11, 2015 6:48 PM > To: Thomas Monjalon; Vladislav Zolotarov; didier.pallard > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Avi Kivity
On 09/11/2015 07:08 PM, Thomas Monjalon wrote: > 2015-09-11 18:43, Avi Kivity: >> On 09/11/2015 06:12 PM, Vladislav Zolotarov wrote: >>> On Sep 11, 2015 5:55 PM, "Thomas Monjalon" >> > wrote: 2015-09-11 17:47, Avi Kivity: > On 09/11/2015 05:25 PM,

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Avi Kivity
ct: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 >> for all NICs but 82598 >> >> On Sep 11, 2015 6:43 PM, "Avi Kivity" wrote: >>> On 09/11/2015 06:12 PM, Vladislav Zolotarov wrote: >>>> >>>> On Sep 11, 2015 5:55 PM,

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Vladislav Zolotarov
On Sep 11, 2015 7:09 PM, "Thomas Monjalon" wrote: > > 2015-09-11 18:43, Avi Kivity: > > On 09/11/2015 06:12 PM, Vladislav Zolotarov wrote: > > > On Sep 11, 2015 5:55 PM, "Thomas Monjalon" > > > wrote: > > > > 2015-09-11 17:47, Avi Kivity: > > > > > On

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Vladislav Zolotarov
at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 > > for all NICs but 82598 > > > > On Sep 11, 2015 6:43 PM, "Avi Kivity" wrote: > > > > > > On 09/11/2015 06:12 PM, Vladislav Zolotarov wrote: > > >&g

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Vladislav Zolotarov
ev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 > > for all NICs but 82598 > > > > On Sep 11, 2015 5:55 PM, "Thomas Monjalon" > > wrote: > > > > > > 2015-09-11 17:47, Avi Kivity: &

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Vladislav Zolotarov
On Sep 11, 2015 6:43 PM, "Avi Kivity" wrote: > > On 09/11/2015 06:12 PM, Vladislav Zolotarov wrote: >> >> >> On Sep 11, 2015 5:55 PM, "Thomas Monjalon" wrote: >> > >> > 2015-09-11 17:47, Avi Kivity: >> > > On 09/11/2015 05:25 PM, didier.pallard wrote: >> > > > On 08/25/2015 08:52 PM, Vlad

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Avi Kivity
On 09/11/2015 06:12 PM, Vladislav Zolotarov wrote: > > > On Sep 11, 2015 5:55 PM, "Thomas Monjalon" > wrote: > > > > 2015-09-11 17:47, Avi Kivity: > > > On 09/11/2015 05:25 PM, didier.pallard wrote: > > > > On 08/25/2015 08:52 PM, Vlad Zolotarov wrote: > > >

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Vladislav Zolotarov
t; Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598 > > > > 2015-08-25 20:13, Zhang, Helin: > > > Yes, I got the perfect answers. Thank you very much! > > > I just wanted to make

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Vladislav Zolotarov
On Sep 11, 2015 5:55 PM, "Thomas Monjalon" wrote: > > 2015-09-11 17:47, Avi Kivity: > > On 09/11/2015 05:25 PM, didier.pallard wrote: > > > On 08/25/2015 08:52 PM, Vlad Zolotarov wrote: > > >> > > >> Helin, the issue has been seen on x540 devices. Pls., see a chapter > > >> 7.2.1.1 of x540

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Thomas Monjalon
2015-09-11 18:43, Avi Kivity: > On 09/11/2015 06:12 PM, Vladislav Zolotarov wrote: > > On Sep 11, 2015 5:55 PM, "Thomas Monjalon" > > wrote: > > > 2015-09-11 17:47, Avi Kivity: > > > > On 09/11/2015 05:25 PM, didier.pallard wrote: > > > > > Hi vlad, > > > > >

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Avi Kivity
On 09/11/2015 05:25 PM, didier.pallard wrote: > On 08/25/2015 08:52 PM, Vlad Zolotarov wrote: >> >> Helin, the issue has been seen on x540 devices. Pls., see a chapter >> 7.2.1.1 of x540 devices spec: >> >> A packet (or multiple packets in transmit segmentation) can span any >> number of >>

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Matthew Hall > Sent: Friday, September 11, 2015 6:18 PM > To: Vladislav Zolotarov > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for &g

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread didier.pallard
On 08/25/2015 08:52 PM, Vlad Zolotarov wrote: > > Helin, the issue has been seen on x540 devices. Pls., see a chapter > 7.2.1.1 of x540 devices spec: > > A packet (or multiple packets in transmit segmentation) can span any > number of > buffers (and their descriptors) up to a limit of 40 minus

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladislav Zolotarov > Sent: Friday, September 11, 2015 5:04 PM > To: Avi Kivity > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 > f

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vladislav Zolotarov > Sent: Friday, September 11, 2015 4:13 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 > f

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Matthew Hall
On Fri, Sep 11, 2015 at 05:42:48PM +, Ananyev, Konstantin wrote: > As I remember, with freebsd stack when TSO is on it was not unusual to see > chains of ~30 segments. > That's over port with 'normal' mtu (1.5K). > Konstantin This makes things quite tricky, because the TSO logic itself

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Matthew Hall
On Fri, Sep 11, 2015 at 07:18:20PM +0300, Vladislav Zolotarov wrote: > We thought about linearization too. It's doable with extra mempool and it > may be optional so that those that don't need could compile it out and/or > disable it in a runtime... High-level question. How realistic is sending a

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-11 Thread Thomas Monjalon
2015-09-11 17:47, Avi Kivity: > On 09/11/2015 05:25 PM, didier.pallard wrote: > > On 08/25/2015 08:52 PM, Vlad Zolotarov wrote: > >> > >> Helin, the issue has been seen on x540 devices. Pls., see a chapter > >> 7.2.1.1 of x540 devices spec: > >> > >> A packet (or multiple packets in transmit

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-09 Thread Thomas Monjalon
2015-08-25 20:13, Zhang, Helin: > Yes, I got the perfect answers. Thank you very much! > I just wanted to make sure the test case was OK with the limit of maximum > number of descriptors, as I heard there is a hang issue on other NICs of > using more descriptors than hardware allowed. > OK. I am

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-09-09 Thread Ananyev, Konstantin
Hi Thomas, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, September 09, 2015 1:19 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-26 Thread Vlad Zolotarov
ystems.com > <mailto:vladz at cloudius-systems.com>] > > > Sent: Tuesday, August 25, 2015 11:53 AM > > > To: Zhang, Helin > > > Cc: Lu, Wenzhuo; dev at dpdk.org <mailto:dev at dpdk.org> > > > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-25 Thread Vladislav Zolotarov
> We may need a check of this somewhere. Of cause the point you > > > indicated we also need to carefully investigate or fix. > > > > > > Regards, > > > > > > Helin > > > > > > *From:*Vladislav Zolotarov [mailto:vladz at cloudius-systems.com]

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-25 Thread Vladislav Zolotarov
Helin > > > > From: Zhang, Helin > Sent: Wednesday, August 19, 2015 10:29 AM > To: Vladislav Zolotarov > Cc: Lu, Wenzhuo; dev at dpdk.org > > Subject: RE: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598 > > > > Hi Vlad &g

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-25 Thread Zhang, Helin
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Tuesday, August 25, 2015 11:53 AM > To: Zhang, Helin > Cc: Lu, Wenzhuo; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for &g

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-25 Thread Ananyev, Konstantin
t; > >>>> -Original Message- > >>>> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > >>>> Sent: Wednesday, August 19, 2015 11:03 AM > >>>> To: Ananyev, Konstantin; Lu, Wenzhuo > >>>> Cc: dev at dpdk.org > &

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-20 Thread Vlad Zolotarov
>>> To: Ananyev, Konstantin; Lu, Wenzhuo >>> Cc: dev at dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh >>> above 1 for all NICs but 82598 >>> >>> >>> >>> On 08/19/15 10:43, Ananyev, Konstanti

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-20 Thread Ananyev, Konstantin
Hi Vlad, > -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Wednesday, August 19, 2015 11:03 AM > To: Ananyev, Konstantin; Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-19 Thread Zhang, Helin
, Helin Subject: RE: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598 On Aug 19, 2015 03:42, "Lu, Wenzhuo" mailto:wenzhuo.lu at intel.com>> wrote: > > Hi Helin, > > > -Original Message- > > From: dev [mailto:dev-b

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-19 Thread Vlad Zolotarov
On 08/19/15 10:43, Ananyev, Konstantin wrote: > Hi Vlad, > Sorry for delay with review, I am OOO till next week. > Meanwhile, few questions/comments from me. Hi, Konstantin, long time no see... ;) > >> This patch fixes the Tx hang we were constantly hitting with a >> seastar-based >>

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-19 Thread Vladislav Zolotarov
t; -Original Message- > > >> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > > >> Sent: Thursday, August 13, 2015 11:07 AM > > >> To: dev at dpdk.org > > >> Cc: Zhang, Helin; Ananyev, Konstantin; avi at cloudius-systems.com;

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-19 Thread Ananyev, Konstantin
Hi Vlad, Sorry for delay with review, I am OOO till next week. Meanwhile, few questions/comments from me. > > > > > > > >> This patch fixes the Tx hang we were constantly hitting with a > seastar-based > > > >> application on x540 NIC. > > > > Could you help to share with us how to reproduce

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-19 Thread Lu, Wenzhuo
Hi Helin, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Friday, August 14, 2015 1:38 PM > To: Zhang, Helin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for >

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-14 Thread Vlad Zolotarov
ems.com; Vlad >> Zolotarov >> Subject: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all >> NICs but 82598 >> >> According to 82599 and x540 HW specifications RS bit *must* be set in the >> last >> descriptor of *every* packet. > Ther

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-13 Thread Vlad Zolotarov
According to 82599 and x540 HW specifications RS bit *must* be set in the last descriptor of *every* packet. This patch fixes the Tx hang we were constantly hitting with a seastar-based application on x540 NIC. Signed-off-by: Vlad Zolotarov --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 +

[dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all NICs but 82598

2015-08-13 Thread Zhang, Helin
> Sent: Thursday, August 13, 2015 11:07 AM > To: dev at dpdk.org > Cc: Zhang, Helin; Ananyev, Konstantin; avi at cloudius-systems.com; Vlad > Zolotarov > Subject: [dpdk-dev] [PATCH v1] ixgbe_pmd: forbid tx_rs_thresh above 1 for all > NICs but 82598 > > According to 82599 and