Re: [dpdk-dev] [PATCH v1] net/ice: refactor flow pattern parser

2020-11-17 Thread Cao, Yahui
> -Original Message- > From: Yan, Zhirun > Sent: Wednesday, November 18, 2020 11:15 AM > To: Cao, Yahui > Cc: dev@dpdk.org; Zhang, Qi Z ; Wang, Xiao W > ; Su, Simei > Subject: [PATCH v1] net/ice: refactor flow pattern parser > > * Cao, Yahui [2020-11-17 23:31:40 +0800]: > > > Hi Z

[dpdk-dev] [PATCH v1] net/ice: refactor flow pattern parser

2020-11-17 Thread Yan, Zhirun
* Cao, Yahui [2020-11-17 23:31:40 +0800]: > Hi Zhirun, > > I think it is great to refactor ice fdir to differentiate inner and > outer field vector in a more clear way. Thanks for your commit. > It seems there still needs some effort to complete this patch. > > > -Origina

Re: [dpdk-dev] [PATCH v1] net/ice: refactor flow pattern parser

2020-11-17 Thread Cao, Yahui
Hi Zhirun, I think it is great to refactor ice fdir to differentiate inner and outer field vector in a more clear way. Thanks for your commit. It seems there still needs some effort to complete this patch. > -Original Message- > From: Yan, Zhirun > Sent: Tuesday, Novem

[dpdk-dev] [PATCH v1] net/ice: refactor flow pattern parser

2020-11-17 Thread Zhirun Yan
Distinguish inner/outer fields. And avoid too many nested conditionals in each type's parser. Signed-off-by: Zhirun Yan --- drivers/net/ice/ice_fdir_filter.c | 504 -- 1 file changed, 269 insertions(+), 235 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c