Re: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

>> >> Using double negation is not very readable IMO, I would prefer this >> converted to a true boolean type if required. >> > > Double negation usage was eliminated. Thanks I acked already. > >> variable ‘set' here should a 0 or 1 already, please expand this code to not >> use >> !!, usi

Re: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

Hi Keith, > -Original Message- > From: Wiles, Keith [mailto:keith.wi...@intel.com] > Sent: Monday, May 14, 2018 3:33 PM > To: Ophir Munk > Cc: dev@dpdk.org; Pascal Mazon ; Thomas > Monjalon ; Olga Shern ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] net

Re: [dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

> On May 7, 2018, at 3:36 AM, Ophir Munk wrote: > > Running testpmd command "flow isolae 0" (i.e. disabling flow > isolation) followed by command "flow isolate 1" (i.e. enabling > flow isolation) may result in a TAP error: > PMD: Kernel refused TC filter rule creation (17): File exists > > R

[dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

Running testpmd command "flow isolae 0" (i.e. disabling flow isolation) followed by command "flow isolate 1" (i.e. enabling flow isolation) may result in a TAP error: PMD: Kernel refused TC filter rule creation (17): File exists Root cause analysis: when disabling flow isolation we keep the loca