Re: [dpdk-dev] [PATCH v1 03/15] net/igc: device initialization

Better to use imperative mode like "add device initialization" for the commit subject. And the subject doesn't match what this patch really does, it's more about adding OS specific functions and definitions other than 'device initialization'. On 03/09, alvinx.zh...@intel.com wrote: >From: Alvin Z

[dpdk-dev] [PATCH v1 03/15] net/igc: device initialization

From: Alvin Zhang Add functions and definitions that are OS specified. Add readme too. Signed-off-by: Alvin Zhang --- drivers/net/igc/Makefile | 46 +++ drivers/net/igc/base/README| 23 drivers/net/igc/base/e1000_osdep.c | 64 + drivers/net/igc/base/e1000_