Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2023-06-12 Thread Stephen Hemminger
On Mon, 20 Apr 2020 19:34:43 +0200 Lukasz Wojciechowski wrote: > > Note, this means that you need to ensure all debug printouts from libs and > > drivers are using the RTE_LOG macros so can be runtime controlled. I think > > that may be some distance from reality right now. > > > > Even if we do

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-07-14 Thread Ananyev, Konstantin
Hi Lukasz, > I've just pushed v3 with minor fixes and mbuf performance tests. There are 6 > very simple tests: > * alloc_free allocates and frees mbufs from/to mempool one by one > * bulk_alloc_free does the same but in bulks > * data_manipulation uses few functions containing sanity check

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-07-09 Thread Lukasz Wojciechowski
W dniu 22.04.2020 o 14:24, Thomas Monjalon pisze: > 22/04/2020 13:29, Ananyev, Konstantin: >>> 22/04/2020 12:55, Bruce Richardson: On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: > W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: >> 21/04/2020 22:58, Lukasz Woj

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-22 Thread Bruce Richardson
On Wed, Apr 22, 2020 at 01:52:21PM +0200, Lukasz Wojciechowski wrote: > > W dniu 22.04.2020 o 13:02, Thomas Monjalon pisze: > > 22/04/2020 12:55, Bruce Richardson: > >> On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: > >>> W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: > >

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-22 Thread Thomas Monjalon
22/04/2020 13:29, Ananyev, Konstantin: > > 22/04/2020 12:55, Bruce Richardson: > > > On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: > > > > W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: > > > > > 21/04/2020 22:58, Lukasz Wojciechowski: > > > > >> W dniu 21.04.2020 o 02:32

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-22 Thread Lukasz Wojciechowski
W dniu 22.04.2020 o 13:02, Thomas Monjalon pisze: > 22/04/2020 12:55, Bruce Richardson: >> On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: >>> W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: 21/04/2020 22:58, Lukasz Wojciechowski: > W dniu 21.04.2020 o 02:32, Anan

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-22 Thread Ananyev, Konstantin
> > 22/04/2020 12:55, Bruce Richardson: > > On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: > > > W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: > > > > 21/04/2020 22:58, Lukasz Wojciechowski: > > > >> W dniu 21.04.2020 o 02:32, Ananyev, Konstantin pisze: > > > >

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-22 Thread Bruce Richardson
On Wed, Apr 22, 2020 at 01:02:42PM +0200, Thomas Monjalon wrote: > 22/04/2020 12:55, Bruce Richardson: > > On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: > > > W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: > > > > 21/04/2020 22:58, Lukasz Wojciechowski: > > > >> W dniu 21

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-22 Thread Thomas Monjalon
22/04/2020 12:55, Bruce Richardson: > On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: > > W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: > > > 21/04/2020 22:58, Lukasz Wojciechowski: > > >> W dniu 21.04.2020 o 02:32, Ananyev, Konstantin pisze: > > >>> I am agree wit

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-22 Thread Bruce Richardson
On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: > > W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: > > 21/04/2020 22:58, Lukasz Wojciechowski: > >> W dniu 21.04.2020 o 02:32, Ananyev, Konstantin pisze: > >>> I am agree with Cristian concern here: that patch removes

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-22 Thread Lukasz Wojciechowski
W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: > 21/04/2020 22:58, Lukasz Wojciechowski: >> W dniu 21.04.2020 o 02:32, Ananyev, Konstantin pisze: >>> I am agree with Cristian concern here: that patch removes ability to >>> enable/disable debug on particular library/PMD. If the

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-21 Thread Thomas Monjalon
21/04/2020 22:58, Lukasz Wojciechowski: > > W dniu 21.04.2020 o 02:32, Ananyev, Konstantin pisze: > > > > I am agree with Cristian concern here: that patch removes ability to > > enable/disable debug on particular library/PMD. If the purpose is > > to > > minimize

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-21 Thread Lukasz Wojciechowski
W dniu 21.04.2020 o 02:32, Ananyev, Konstantin pisze: > > I am agree with Cristian concern here: that patch removes ability to > enable/disable debug on particular library/PMD. If the purpose is to > minimize number of config compile options, I wonder can't it be done >>>

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Ananyev, Konstantin
> > > > > > >> I am agree with Cristian concern here: that patch removes > > > > > > >> ability to > > > > > > >> enable/disable debug on particular library/PMD. If the purpose > > > > > > >> is to > > > > > > >> minimize number of config compile options, I wonder can't it be > > > > > > >>

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 07:35:36PM +0200, Thomas Monjalon wrote: > 20/04/2020 19:30, Bruce Richardson: > > On Mon, Apr 20, 2020 at 07:21:32PM +0200, Thomas Monjalon wrote: > > > 20/04/2020 19:11, Bruce Richardson: > > > > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > >

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Thomas Monjalon
20/04/2020 19:30, Bruce Richardson: > On Mon, Apr 20, 2020 at 07:21:32PM +0200, Thomas Monjalon wrote: > > 20/04/2020 19:11, Bruce Richardson: > > > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > > > > On Mon, Apr

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Lukasz Wojciechowski
W dniu 20.04.2020 o 19:30, Bruce Richardson pisze: > On Mon, Apr 20, 2020 at 07:21:32PM +0200, Thomas Monjalon wrote: >> 20/04/2020 19:11, Bruce Richardson: >>> On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > On M

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 07:21:32PM +0200, Thomas Monjalon wrote: > 20/04/2020 19:11, Bruce Richardson: > > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > > > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > > > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev,

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 06:11:30PM +0100, Bruce Richardson wrote: > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: > > >>> > > > >> I am agr

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Thomas Monjalon
20/04/2020 19:11, Bruce Richardson: > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: > > >>> > > > >> I am agree with Cristian concern here:

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: > >>> > >> I am agree with Cristian concern here: that patch removes ability to > >> enable/disable

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Lukasz Wojciechowski
W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: >>> >>> -Original Message- From: Lukasz Wojciechowski Sent: Friday, April 17, 2020 10:57 PM To: Thomas Monjalon ; Igor Russkikh ; Pavel Belou

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: > > > > > > > > > -Original Message- > > > From: Lukasz Wojciechowski > > > Sent: Friday, April 17, 2020 10:57 PM > > > To: Thomas Monjalon ; Igor Russkikh > > > ; Pavel Belous ; > > > Lu, Wenzhuo ; Marcin Wojtas > > >

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Ananyev, Konstantin
> > > > > -Original Message- > > From: Lukasz Wojciechowski > > Sent: Friday, April 17, 2020 10:57 PM > > To: Thomas Monjalon ; Igor Russkikh > > ; Pavel Belous ; > > Lu, Wenzhuo ; Marcin Wojtas > > ; Michal Krawczyk ; Guy Tzalik > > ; Evgeny Schemeilin ; Igor > > Chauskin ; John Daley

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Lukasz Wojciechowski > Sent: Friday, April 17, 2020 10:57 PM > To: Thomas Monjalon ; Igor Russkikh > ; Pavel Belous ; > Lu, Wenzhuo ; Marcin Wojtas > ; Michal Krawczyk ; Guy Tzalik > ; Evgeny Schemeilin ; Igor > Chauskin ; John Daley ; Hyong > Youb Kim ; Zhan

[dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-17 Thread Lukasz Wojciechowski
Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_ETHDEV_DEBUG. The old define is completely removed from source code and config. The changes were applied also to all drivers using this flag. Signed-off-by: Lukasz Wojciechowski --- config/common_base | 1 - drivers