Re: [dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-23 Thread Jerin Jacob
On Mon, Mar 23, 2020 at 10:14 PM Mattias Rönnblom wrote: > > On 2020-03-23 16:08, Jerin Jacob wrote: > > On Mon, Mar 23, 2020 at 8:13 PM Mattias Rönnblom > > wrote: > >> On 2020-03-23 14:37, Jerin Jacob wrote: > > + } > > + > > + /* Initialize the trace point */ > > +

Re: [dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-23 Thread Mattias Rönnblom
On 2020-03-23 16:08, Jerin Jacob wrote: > On Mon, Mar 23, 2020 at 8:13 PM Mattias Rönnblom > wrote: >> On 2020-03-23 14:37, Jerin Jacob wrote: > + } > + > + /* Initialize the trace point */ > + if (rte_strscpy(tp->name, name, TRACE_POINT_NAME_SIZE) < 0) { > +

Re: [dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-23 Thread Jerin Jacob
On Mon, Mar 23, 2020 at 8:13 PM Mattias Rönnblom wrote: > > On 2020-03-23 14:37, Jerin Jacob wrote: > >>> + } > >>> + > >>> + /* Initialize the trace point */ > >>> + if (rte_strscpy(tp->name, name, TRACE_POINT_NAME_SIZE) < 0) { > >>> + trace_err("name is too long"); > >>>

Re: [dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-23 Thread Mattias Rönnblom
On 2020-03-23 14:37, Jerin Jacob wrote: >>> + } >>> + >>> + /* Initialize the trace point */ >>> + if (rte_strscpy(tp->name, name, TRACE_POINT_NAME_SIZE) < 0) { >>> + trace_err("name is too long"); >>> + rte_errno = E2BIG; >>> + goto free; >>> + }

Re: [dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-23 Thread Jerin Jacob
On Thu, Mar 19, 2020 at 3:33 PM Mattias Rönnblom wrote: > > On 2020-03-18 20:02, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > +int > > +__rte_trace_point_register(rte_trace_t handle, const char *name, uint32_t > > level, > > + void (*fn)(void)) > Maybe a more des

Re: [dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-19 Thread Mattias Rönnblom
On 2020-03-18 20:02, jer...@marvell.com wrote: > From: Jerin Jacob > > The consumers of trace API defines the tracepoint and registers > to eal. Internally these tracepoints will be stored in STAILQ > for future use. This patch implements the tracepoint > registration function. > > Signed-off-by:

[dpdk-dev] [PATCH v1 03/32] eal/trace: implement trace register API

2020-03-18 Thread jerinj
From: Jerin Jacob The consumers of trace API defines the tracepoint and registers to eal. Internally these tracepoints will be stored in STAILQ for future use. This patch implements the tracepoint registration function. Signed-off-by: Jerin Jacob --- MAINTAINERS