[dpdk-dev] [PATCH v1 1/7] ethdev: expose flow API error helper

2017-10-05 Thread Adrien Mazarguil
rte_flow_error_set() is a convenient helper to initialize error objects. Since there is no fundamental reason to prevent applications from using it, expose it through the public interface after modifying its return value from positive to negative. This is done for consistency with the rest of the

Re: [dpdk-dev] [PATCH v1 1/7] ethdev: expose flow API error helper

2017-10-11 Thread Thomas Monjalon
05/10/2017 11:49, Adrien Mazarguil: > rte_flow_error_set() is a convenient helper to initialize error objects. > > Since there is no fundamental reason to prevent applications from using it, > expose it through the public interface after modifying its return value > from positive to negative. This

Re: [dpdk-dev] [PATCH v1 1/7] ethdev: expose flow API error helper

2017-10-11 Thread Adrien Mazarguil
On Wed, Oct 11, 2017 at 11:23:12AM +0200, Thomas Monjalon wrote: > 05/10/2017 11:49, Adrien Mazarguil: > > rte_flow_error_set() is a convenient helper to initialize error objects. > > > > Since there is no fundamental reason to prevent applications from using it, > > expose it through the public i

Re: [dpdk-dev] [PATCH v1 1/7] ethdev: expose flow API error helper

2017-10-11 Thread Aaron Conole
Adrien Mazarguil writes: > On Wed, Oct 11, 2017 at 11:23:12AM +0200, Thomas Monjalon wrote: >> 05/10/2017 11:49, Adrien Mazarguil: >> > rte_flow_error_set() is a convenient helper to initialize error objects. >> > >> > Since there is no fundamental reason to prevent applications from using it, >

Re: [dpdk-dev] [PATCH v1 1/7] ethdev: expose flow API error helper

2017-10-12 Thread Neil Horman
On Wed, Oct 11, 2017 at 03:05:47PM -0400, Aaron Conole wrote: > Adrien Mazarguil writes: > > > On Wed, Oct 11, 2017 at 11:23:12AM +0200, Thomas Monjalon wrote: > >> 05/10/2017 11:49, Adrien Mazarguil: > >> > rte_flow_error_set() is a convenient helper to initialize error objects. > >> > > >> > S

Re: [dpdk-dev] [PATCH v1 1/7] ethdev: expose flow API error helper

2017-10-12 Thread Adrien Mazarguil
On Wed, Oct 11, 2017 at 03:05:47PM -0400, Aaron Conole wrote: > Adrien Mazarguil writes: > > > On Wed, Oct 11, 2017 at 11:23:12AM +0200, Thomas Monjalon wrote: > >> 05/10/2017 11:49, Adrien Mazarguil: > >> > rte_flow_error_set() is a convenient helper to initialize error objects. > >> > > >> > S