Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-07-09 Thread David Marchand
On Thu, Jun 24, 2021 at 4:35 PM Burakov, Anatoly wrote: > Right, so the idea is store the PMD-specific data in the monitor > condition, and leave it to the callback to interpret it. > > The obvious question then is, how many values is enough? Two? Three? > Four? This option doesn't really solve th

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Burakov, Anatoly
On 24-Jun-21 4:25 PM, Ananyev, Konstantin wrote: I did a quick prototype for this, and i don't think it is going to work. Callbacks with just "current value" as argument will be pretty limited and will only really work for cases where we know what we are expecting. However, for cases like even

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Ananyev, Konstantin
> >> I did a quick prototype for this, and i don't think it is going to > >> work. > >> > >> Callbacks with just "current value" as argument will be pretty limited > >> and will only really work for cases where we know what we are > >> expecting. > >> However, for cas

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Burakov, Anatoly
On 24-Jun-21 3:57 PM, Ananyev, Konstantin wrote: I did a quick prototype for this, and i don't think it is going to work. Callbacks with just "current value" as argument will be pretty limited and will only really work for cases where we know what we are expecting. However, for cases like eve

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Ananyev, Konstantin
> I did a quick prototype for this, and i don't think it is going to work. > > Callbacks with just "current value" as argument will be pretty limited > and will only really work for cases where we know what we are expecting. > However, for cases like event/dlb or net/mlx5

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Burakov, Anatoly
On 24-Jun-21 10:47 AM, Ananyev, Konstantin wrote: I did a quick prototype for this, and i don't think it is going to work. Callbacks with just "current value" as argument will be pretty limited and will only really work for cases where we know what we are expecting. However, for cases like

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-24 Thread Ananyev, Konstantin
> >>> > Previously, the semantics of power monitor were such that we were > checking current value against the expected value, and if they > matched, > then the sleep was aborted. This is somewhat inflexible, because it > only > allowed u

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 2:27 PM, Ananyev, Konstantin wrote: On 23-Jun-21 12:00 PM, Ananyev, Konstantin wrote: Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexib

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Ananyev, Konstantin
> On 23-Jun-21 12:00 PM, Ananyev, Konstantin wrote: > > > > > >> Previously, the semantics of power monitor were such that we were > >> checking current value against the expected value, and if they matched, > >> then the sleep was aborted. This is somewhat inflexible, because it

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 12:00 PM, Ananyev, Konstantin wrote: Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specif

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Ananyev, Konstantin
> >>> > Previously, the semantics of power monitor were such that we were > checking current value against the expected value, and if they matched, > then the sleep was aborted. This is somewhat inflexible, because it only > allowed us to check for a specific value. > > >>

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Burakov, Anatoly
On 23-Jun-21 10:55 AM, Ananyev, Konstantin wrote: -Original Message- From: Burakov, Anatoly Sent: Wednesday, June 23, 2021 10:43 AM To: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce Cc: Loftus, Ciara ; Hunt, David Subject: Re: [PATCH v1 1/7] power_intrinsics: allow monitor

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Ananyev, Konstantin
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, June 23, 2021 10:43 AM > To: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce > Cc: Loftus, Ciara ; Hunt, David > Subject: Re: [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion > > On 21-Jun-21 1:56

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-23 Thread Burakov, Anatoly
On 21-Jun-21 1:56 PM, Ananyev, Konstantin wrote: Hi Anatoly, Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check fo

Re: [dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-21 Thread Ananyev, Konstantin
Hi Anatoly, > Previously, the semantics of power monitor were such that we were > checking current value against the expected value, and if they matched, > then the sleep was aborted. This is somewhat inflexible, because it only > allowed us to check for a specific value. > > This commit adds a

[dpdk-dev] [PATCH v1 1/7] power_intrinsics: allow monitor checks inversion

2021-06-01 Thread Anatoly Burakov
Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value. This commit adds an option to reverse the che