Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-10 Thread Ferruh Yigit
On 5/10/2018 1:56 AM, Wei Dai wrote: > This patch check if a input requested offloading is valid or not. > Any reuqested offloading must be supported in the device capabilities. > Any offloading is disabled by default if it is not set in the parameter > dev_conf->[rt]xmode.offloads to rte_eth_dev_c

Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-10 Thread Ferruh Yigit
On 5/10/2018 10:25 AM, Andrew Rybchenko wrote: > On 05/10/2018 03:56 AM, Wei Dai wrote: >> This patch check if a input requested offloading is valid or not. >> Any reuqested offloading must be supported in the device capabilities. >> Any offloading is disabled by default if it is not set in the par

Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-10 Thread Dai, Wei
Hi, Thomas Thanks for your feedback and guidance. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, May 10, 2018 10:36 AM > To: Dai, Wei > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-10 Thread Andrew Rybchenko
On 05/10/2018 03:56 AM, Wei Dai wrote: This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_confi

Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-09 Thread Thomas Monjalon
Hi, I am checking if this patch comply with goals discussed in the survey: http://dpdk.org/ml/archives/dev/2018-March/094459.html - Allow "forgetting" port offloads in queue offloads setup. - An offload enabled at port level, cannot be disabled at queue level. - Every queue capabilities

Re: [dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-09 Thread Ferruh Yigit
On 5/10/2018 1:56 AM, Wei Dai wrote: > This patch check if a input requested offloading is valid or not. > Any reuqested offloading must be supported in the device capabilities. > Any offloading is disabled by default if it is not set in the parameter > dev_conf->[rt]xmode.offloads to rte_eth_dev_c

[dpdk-dev] [PATCH v10] ethdev: new Rx/Tx offloads API

2018-05-09 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and [rt]x_conf->offloads to rte_e