Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-24 Thread Pattan, Reshma
> -Original Message- > > > > > > + * Similar behavior to rte_bpf_eth callback. > > > + * if BPF program returns zero value for a given packet, > > > + * then it will be ignored. > > > + */ > > Looks like wrong callback name referred in the comment, sho

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-23 Thread Stephen Hemminger
On Thu, 23 Sep 2021 16:11:42 + "Pattan, Reshma" wrote: > > > > +* Similar behavior to rte_bpf_eth callback. > > +* if BPF program returns zero value for a given packet, > > +* then it will be ignored. > > +*/ > Looks like wrong callback name

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-23 Thread Stephen Hemminger
On Thu, 23 Sep 2021 16:11:42 + "Pattan, Reshma" wrote: > > struct pdump_request { > > + uint16_t flags; > Why is the flags type changed from unit32_t unint16_t? Only to pack the structure. They were unused.

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-23 Thread Stephen Hemminger
On Thu, 23 Sep 2021 16:11:42 + "Pattan, Reshma" wrote: > > +/* > > + * Note: version numbers intentionally start at 3 > > + * in order to catch any application built with older out > > + * version of DPDK using incompatible client request format. > > + */ > > enum pdump_version { > > - V1

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-23 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > > +++ b/lib/meson.build > +'bpf', > 'bitratestats', If alphabetical order, should bpf come after bitratestats? > +/* > + * Note: version numbers intentionally start at 3 > + * in order to catch any ap

[dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-16 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally