Add PMD power management feature support to l3fwd-power sample app.
Signed-off-by: Liang Ma <liang.j...@intel.com>
Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
Acked-by: David Hunt <david.h...@intel.com>
---
Notes:
v8:
- Add return status check for queue enable
v6:
- Fixed typos in documentation
---
.../sample_app_ug/l3_forward_power_man.rst | 13 ++++++
examples/l3fwd-power/main.c | 46 ++++++++++++++++++-
2 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst
b/doc/guides/sample_app_ug/l3_forward_power_man.rst
index d7e1dc5813..b10ebe662e 100644
--- a/doc/guides/sample_app_ug/l3_forward_power_man.rst
+++ b/doc/guides/sample_app_ug/l3_forward_power_man.rst
@@ -109,6 +109,8 @@ where,
* --telemetry: Telemetry mode.
+* --pmd-mgmt: PMD power management mode.
+
See :doc:`l3_forward` for details.
The L3fwd-power example reuses the L3fwd command line options.
@@ -455,3 +457,14 @@ reference cycles and accordingly busy rate is set to
either 0% or
The new stats ``empty_poll`` , ``full_poll`` and ``busy_percent`` can be
viewed by running the script
``/usertools/dpdk-telemetry-client.py`` and selecting the menu option ``Send
for global Metrics``.
+
+PMD power management Mode
+-------------------------
+
+The PMD power management mode support for ``l3fwd-power`` is a standalone
mode, in this mode
+``l3fwd-power`` does simple l3fwding along with enable the power saving scheme
on specific
+port/queue/lcore. Main purpose for this mode is to demonstrate how to use the
PMD power management API.
+
+.. code-block:: console
+
+ ./build/examples/dpdk-l3fwd-power -l 1-3 -- --pmd-mgmt -p 0x0f
--config="(0,0,2),(0,1,3)"
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index a48d75f68f..aafa415f0b 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -47,6 +47,7 @@
#include <rte_power_empty_poll.h>
#include <rte_metrics.h>
#include <rte_telemetry.h>
+#include <rte_power_pmd_mgmt.h>
#include "perf_core.h"
#include "main.h"
@@ -199,7 +200,8 @@ enum appmode {
APP_MODE_LEGACY,
APP_MODE_EMPTY_POLL,
APP_MODE_TELEMETRY,
- APP_MODE_INTERRUPT
+ APP_MODE_INTERRUPT,
+ APP_MODE_PMD_MGMT
};
enum appmode app_mode;
@@ -1750,6 +1752,7 @@ parse_ep_config(const char *q_arg)
#define CMD_LINE_OPT_EMPTY_POLL "empty-poll"
#define CMD_LINE_OPT_INTERRUPT_ONLY "interrupt-only"
#define CMD_LINE_OPT_TELEMETRY "telemetry"
+#define CMD_LINE_OPT_PMD_MGMT "pmd-mgmt"
/* Parse the argument given in the command line of the application */
static int
@@ -1771,6 +1774,7 @@ parse_args(int argc, char **argv)
{CMD_LINE_OPT_LEGACY, 0, 0, 0},
{CMD_LINE_OPT_TELEMETRY, 0, 0, 0},
{CMD_LINE_OPT_INTERRUPT_ONLY, 0, 0, 0},
+ {CMD_LINE_OPT_PMD_MGMT, 0, 0, 0},
{NULL, 0, 0, 0}
};
@@ -1881,6 +1885,16 @@ parse_args(int argc, char **argv)
printf("telemetry mode is enabled\n");
}
+ if (!strncmp(lgopts[option_index].name,
+ CMD_LINE_OPT_PMD_MGMT,
+ sizeof(CMD_LINE_OPT_PMD_MGMT))) {
+ if (app_mode != APP_MODE_DEFAULT) {
+ printf(" power mgmt mode is mutually
exclusive with other modes\n");
+ return -1;
+ }
+ app_mode = APP_MODE_PMD_MGMT;
+ printf("PMD power mgmt mode is enabled\n");
+ }
if (!strncmp(lgopts[option_index].name,
CMD_LINE_OPT_INTERRUPT_ONLY,
sizeof(CMD_LINE_OPT_INTERRUPT_ONLY))) {
@@ -2437,6 +2451,8 @@ mode_to_str(enum appmode mode)
return "telemetry";
case APP_MODE_INTERRUPT:
return "interrupt-only";
+ case APP_MODE_PMD_MGMT:
+ return "pmd mgmt";
default:
return "invalid";
}
@@ -2705,6 +2721,17 @@ main(int argc, char **argv)
} else if (!check_ptype(portid))
rte_exit(EXIT_FAILURE,
"PMD can not provide needed ptypes\n");
+ if (app_mode == APP_MODE_PMD_MGMT) {
+ ret = rte_power_pmd_mgmt_queue_enable(lcore_id,
+ portid, queueid,
+ RTE_POWER_MGMT_TYPE_SCALE);
+
+ if (ret < 0)
+ rte_exit(EXIT_FAILURE,
+ "rte_power_pmd_mgmt enable: err=%d, "
+ "port=%d\n", ret, portid);
+
+ }
}
}
@@ -2790,6 +2817,9 @@ main(int argc, char **argv)
SKIP_MAIN);
} else if (app_mode == APP_MODE_INTERRUPT) {
rte_eal_mp_remote_launch(main_intr_loop, NULL, CALL_MAIN);
+ } else if (app_mode == APP_MODE_PMD_MGMT) {
+ rte_eal_mp_remote_launch(main_telemetry_loop, NULL,
+ CALL_MAIN);
}
if (app_mode == APP_MODE_EMPTY_POLL || app_mode == APP_MODE_TELEMETRY)
@@ -2816,6 +2846,20 @@ main(int argc, char **argv)
if (app_mode == APP_MODE_EMPTY_POLL)
rte_power_empty_poll_stat_free();
+ if (app_mode == APP_MODE_PMD_MGMT) {
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+ if (rte_lcore_is_enabled(lcore_id) == 0)
+ continue;
+ qconf = &lcore_conf[lcore_id];
+ for (queue = 0; queue < qconf->n_rx_queue; ++queue) {
+ portid = qconf->rx_queue_list[queue].port_id;
+ queueid = qconf->rx_queue_list[queue].queue_id;
+ rte_power_pmd_mgmt_queue_disable(lcore_id,
+ portid, queueid);
+ }
+ }
+ }
+
if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&
deinit_power_library())
rte_exit(EXIT_FAILURE, "deinit_power_library failed\n");
--
2.17.1
