Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-25 Thread Thomas Monjalon
25/10/2017 13:10, Iremonger, Bernard: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 24/10/2017 19:28, Bernard Iremonger: > > > # > > > +# Compile librte_classify > > > +# > > > +CONFIG_RTE_LIBRTE_FLOW_CLASSIFY=y > > > +CONFIG_RTE_LIBRTE_CLASSIFY_DEBUG=n > > > > The debu

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-25 Thread Iremonger, Bernard
m; Singh, > Jasvinder > Subject: Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify > library > > 24/10/2017 19:28, Bernard Iremonger: > > # > > +# Compile librte_classify > > +# > > +CONFIG_RTE_LIBRTE_FLOW_CLASSIFY=y > > +CONFIG_RTE_LIBRTE_C

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > --- a/doc/guides/rel_notes/release_17_11.rst > +++ b/doc/guides/rel_notes/release_17_11.rst > +* **Added the Flow Classification Library.** > + > + Added the Flow Classification library, it provides an API for DPDK > + applications to classify an input packe

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > --- a/doc/guides/rel_notes/release_17_11.rst > +++ b/doc/guides/rel_notes/release_17_11.rst > @@ -165,6 +165,11 @@ New Features >checksums, and doesn't update checksums for output packets. >Additionally, the GSO library doesn't process IP fragmented pa

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > +F: doc/guides/sample_app_ug/flow_classify.rst > +F: doc/guides/prog_guide/flow_classify_lib.rst These files are listed in MAINTAINERS but they are missing. They must be removed from the list.

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > --- /dev/null > +++ b/lib/librte_flow_classify/rte_flow_classify_version.map > @@ -0,0 +1,13 @@ > +EXPERIMENTAL { > + global: > + > + rte_flow_classifier_create; > + rte_flow_classifier_free; > + rte_flow_classifier_query; > + rte

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > +/** > + * @file > + * > + * RTE Flow Classify Library > + * > + * This library provides flow record information with some measured > properties. I would add the EXPERIMENTAL tag here: @b EXPERIMENTAL: this API may change without prior notice

Re: [dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Thomas Monjalon
24/10/2017 19:28, Bernard Iremonger: > # > +# Compile librte_classify > +# > +CONFIG_RTE_LIBRTE_FLOW_CLASSIFY=y > +CONFIG_RTE_LIBRTE_CLASSIFY_DEBUG=n The debug option is still there but seems not used. I guess I can remove it?

[dpdk-dev] [PATCH v11 1/4] flow_classify: add flow classify library

2017-10-24 Thread Bernard Iremonger
From: Ferruh Yigit The following APIs's are implemented in the librte_flow_classify library: rte_flow_classifier_create rte_flow_classifier_free rte_flow_classifier_query rte_flow_classify_table_create rte_flow_classify_table_entry_add rte_flow_classify_table_entry_delete The following librte_t