Re: [dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-15 Thread 谢华伟(此时此刻)
On 2021/3/15 18:19, David Marchand wrote: #else #define IO_COND(addr, is_pio, is_mmio) do { \ is_mmio; \ } while (0) #endif We should not just copy/paste kernel code. Plus here, this seems a bit overkill. And there are other parts in thi

Re: [dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-15 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Monday, March 15, 2021 18:20 > To: Wang, Haiyue ; 谢华伟(此时此刻) > > Cc: maxime.coque...@redhat.com; Yigit, Ferruh ; > dev@dpdk.org; Burakov, Anatoly > ; xuemi...@nvidia.com; gr...@u256.net > Subject: Re: [dpdk-d

Re: [dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-15 Thread David Marchand
On Thu, Mar 11, 2021 at 7:43 AM Wang, Haiyue wrote: > Like kernel use macro to do pio and mmio, maybe we can also to do so for > making code clean: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/iomap.c > > #define IO_COND(addr, is_pio, is_mmio) do {

Re: [dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-10 Thread Wang, Haiyue
gt; 谢华伟(此时此刻) > Subject: [dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport > accessors > > With I/O BAR, we get PIO(port-mapped I/O) address. > With MMIO(memory-mapped I/O) BAR, we get mapped virtual address. > We distinguish PIO and MMIO by their address range like

[dpdk-dev] [PATCH v11 2/2] bus/pci: support MMIO in PCI ioport accessors

2021-03-10 Thread 谢华伟(此时此刻)
With I/O BAR, we get PIO(port-mapped I/O) address. With MMIO(memory-mapped I/O) BAR, we get mapped virtual address. We distinguish PIO and MMIO by their address range like how kernel does, i.e, address below 64K is PIO. ioread/write8/16/32 is provided to access PIO/MMIO. By the way, for virtio on a