[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-17 Thread Olivier Matz
Hi David, If you plan to do a v14 for this API comment, I'm wondering if the documentation could be slightly modified too. I think "external mempool manager" was the legacy name for the feature, but maybe it could be changed in "alternative mempool handlers" or "changing the

[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-17 Thread Olivier Matz
Hi David, While testing Lazaros' patch, I found an issue in this series. I the test application is started with --no-huge, it does not work, the mempool_autotest does not work. Please find the exaplanation below: On 06/16/2016 02:30 PM, David Hunt wrote: > @@ -386,9 +352,9 @@

[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-17 Thread Hunt, David
On 17/6/2016 11:18 AM, Olivier Matz wrote: > Hi David, > > While testing Lazaros' patch, I found an issue in this series. > I the test application is started with --no-huge, it does not work, > the mempool_autotest does not work. Please find the exaplanation > below: > > On 06/16/2016 02:30 PM,

[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-17 Thread Thomas Monjalon
2016-06-17 09:42, Hunt, David: > > On 17/6/2016 9:08 AM, Olivier Matz wrote: > > Hi David, > > > > On 06/17/2016 08:58 AM, Hunt, David wrote: > >> A comment below: > >> > >> On 16/6/2016 1:30 PM, David Hunt wrote: > >>> +/** > >>> + * Set the ops of a mempool. > >>> + * > >>> + * This can only be

[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-17 Thread Hunt, David
On 17/6/2016 10:09 AM, Thomas Monjalon wrote: > 2016-06-17 09:42, Hunt, David: >> On 17/6/2016 9:08 AM, Olivier Matz wrote: >>> Hi David, >>> >>> On 06/17/2016 08:58 AM, Hunt, David wrote: A comment below: On 16/6/2016 1:30 PM, David Hunt wrote: > +/** > + * Set the ops of

[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-17 Thread Olivier Matz
Hi David, On 06/17/2016 08:58 AM, Hunt, David wrote: > A comment below: > > On 16/6/2016 1:30 PM, David Hunt wrote: >> +/** >> + * Set the ops of a mempool. >> + * >> + * This can only be done on a mempool that is not populated, i.e. >> just after >> + * a call to rte_mempool_create_empty(). >>

[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-17 Thread Hunt, David
On 17/6/2016 9:08 AM, Olivier Matz wrote: > Hi David, > > On 06/17/2016 08:58 AM, Hunt, David wrote: >> A comment below: >> >> On 16/6/2016 1:30 PM, David Hunt wrote: >>> +/** >>> + * Set the ops of a mempool. >>> + * >>> + * This can only be done on a mempool that is not populated, i.e. >>>

[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-17 Thread Hunt, David
A comment below: On 16/6/2016 1:30 PM, David Hunt wrote: > +/** > + * Set the ops of a mempool. > + * > + * This can only be done on a mempool that is not populated, i.e. just after > + * a call to rte_mempool_create_empty(). > + * > + * @param mp > + * Pointer to the memory pool. > + * @param

[dpdk-dev] [PATCH v13 1/3] mempool: support external mempool operations

2016-06-16 Thread David Hunt
Until now, the objects stored in a mempool were internally stored in a ring. This patch introduces the possibility to register external handlers replacing the ring. The default behavior remains unchanged, but calling the new function rte_mempool_set_ops_byname() right after