[dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-29 Thread pbhagavatula
From: Pavan Nikhilesh Some PMDs cannot work when certain offloads are enable/disabled, as a workaround PMDs auto enable/disable offloads internally and expose it through dev->data->dev_conf.rxmode.offloads. After device specific dev_configure is called compare the requested offloads to the offlo

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-29 Thread Andrew Rybchenko
On 10/29/19 6:37 PM, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Some PMDs cannot work when certain offloads are enable/disabled, as a workaround PMDs auto enable/disable offloads internally and expose it through dev->data->dev_conf.rxmode.offloads. After device specific dev_configur

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Thomas Monjalon
29/10/2019 17:53, Andrew Rybchenko: > On 10/29/19 6:37 PM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > +static int > > +_rte_eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads, > > I

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Thomas Monjalon
29/10/2019 16:37, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > +static int > +_rte_eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads, > +uint64_t set_offloads, > +

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Matan Azrad
Hi Pavan From: Pavan Nikhilesh > Some PMDs cannot work when certain offloads are enable/disabled, as a > workaround PMDs auto enable/disable offloads internally and expose it > through dev->data->dev_conf.rxmode.offloads. > > After device specific dev_configure is called compare the requested of

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Pavan Nikhilesh Bhagavatula
Hi Matan, >Hi Pavan > >From: Pavan Nikhilesh >> Some PMDs cannot work when certain offloads are enable/disabled, >as a >> workaround PMDs auto enable/disable offloads internally and expose >it >> through dev->data->dev_conf.rxmode.offloads. >> >> After device specific dev_configure is called comp

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Matan Azrad
From: Pavan Nikhilesh Bhagavatula > Hi Matan, > > >Hi Pavan > > > >From: Pavan Nikhilesh > >> Some PMDs cannot work when certain offloads are enable/disabled, > >as a > >> workaround PMDs auto enable/disable offloads internally and expose > >it > >> through dev->data->dev_conf.rxmode.offloads.

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Pavan Nikhilesh Bhagavatula
>From: Pavan Nikhilesh Bhagavatula >> Hi Matan, >> >> >Hi Pavan >> > >> >From: Pavan Nikhilesh >> >> Some PMDs cannot work when certain offloads are >enable/disabled, >> >as a >> >> workaround PMDs auto enable/disable offloads internally and >expose >> >it >> >> through dev->data->dev_conf.rxmode.

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-01 Thread Andrew Rybchenko
On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: >> From: Pavan Nikhilesh Bhagavatula >>> Hi Matan, >>> Hi Pavan From: Pavan Nikhilesh > Some PMDs cannot work when certain offloads are enable/disabled, as a > workaround PMDs auto enable/disable offloads internally and

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-02 Thread Matan Azrad
Hi From: Andrew Rybchenko > On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: > >> From: Pavan Nikhilesh Bhagavatula > >>> Hi Matan, > >>> > Hi Pavan > > From: Pavan Nikhilesh > > Some PMDs cannot work when certain offloads are enable/disabled, > > as a workaround PMD

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-03 Thread Andrew Rybchenko
On 11/3/19 9:57 AM, Matan Azrad wrote: Hi From: Andrew Rybchenko On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: From: Pavan Nikhilesh Bhagavatula Hi Matan, Hi Pavan From: Pavan Nikhilesh Some PMDs cannot work when certain offloads are enable/disabled, as a workaround PMDs auto e

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-03 Thread Matan Azrad
From: Andrew Rybchenko > On 11/3/19 9:57 AM, Matan Azrad wrote: > > Hi > > > > From: Andrew Rybchenko > >> On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh Bhagavatula > > Hi Matan, > > > >> Hi Pavan > >> > >> From: Pavan Nikhilesh > >>

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-05 Thread Andrew Rybchenko
On 11/3/19 6:16 PM, Matan Azrad wrote > From: Andrew Rybchenko >> On 11/3/19 9:57 AM, Matan Azrad wrote: >>> Hi >>> >>> From: Andrew Rybchenko On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: >> From: Pavan Nikhilesh Bhagavatula >>> Hi Matan, >>> Hi Pavan >

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-05 Thread Matan Azrad
From: Andrew Rybchenko > On 11/3/19 6:16 PM, Matan Azrad wrote > > From: Andrew Rybchenko > >> On 11/3/19 9:57 AM, Matan Azrad wrote: > >>> Hi > >>> > >>> From: Andrew Rybchenko > On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: > >> From: Pavan Nikhilesh Bhagavatula > >>> Hi

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-05 Thread Andrew Rybchenko
On 11/5/19 5:05 PM, Matan Azrad wrote: > From: Andrew Rybchenko >> On 11/3/19 6:16 PM, Matan Azrad wrote >>> From: Andrew Rybchenko On 11/3/19 9:57 AM, Matan Azrad wrote: > Hi > > From: Andrew Rybchenko >> On 10/31/19 7:33 PM, Pavan Nikhilesh Bhagavatula wrote: From: P

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-05 Thread Matan Azrad
From: Andrew Rybchenko > On 11/5/19 5:05 PM, Matan Azrad wrote: > > From: Andrew Rybchenko > >> On 11/3/19 6:16 PM, Matan Azrad wrote > >>> From: Andrew Rybchenko > On 11/3/19 9:57 AM, Matan Azrad wrote: > > Hi > > > > From: Andrew Rybchenko > >> On 10/31/19 7:33 PM, Pavan Ni

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-06 Thread Andrew Rybchenko
On 11/6/19 9:58 AM, Matan Azrad wrote: > > > From: Andrew Rybchenko >> On 11/5/19 5:05 PM, Matan Azrad wrote: >>> From: Andrew Rybchenko On 11/3/19 6:16 PM, Matan Azrad wrote > From: Andrew Rybchenko >> On 11/3/19 9:57 AM, Matan Azrad wrote: >>> Hi >>> >>> From: Andrew R

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-06 Thread Matan Azrad
Hi From: Andrew Rybchenko > On 11/6/19 9:58 AM, Matan Azrad wrote: > > > > > > From: Andrew Rybchenko > >> On 11/5/19 5:05 PM, Matan Azrad wrote: > >>> From: Andrew Rybchenko > On 11/3/19 6:16 PM, Matan Azrad wrote > > From: Andrew Rybchenko > >> On 11/3/19 9:57 AM, Matan Azrad wrote:

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Andrew Rybchenko
On 11/7/19 9:56 AM, Matan Azrad wrote: > Hi > > From: Andrew Rybchenko >> On 11/6/19 9:58 AM, Matan Azrad wrote: >>> >>> >>> From: Andrew Rybchenko On 11/5/19 5:05 PM, Matan Azrad wrote: > From: Andrew Rybchenko >> On 11/3/19 6:16 PM, Matan Azrad wrote >>> From: Andrew Rybchenko >

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Matan Azrad
From: Andrew Rybchenko > Sent: Friday, November 8, 2019 12:12 PM > To: Matan Azrad ; Pavan Nikhilesh Bhagavatula > ; ferruh.yi...@intel.com; Jerin Jacob > Kollanukkaran ; Thomas Monjalon > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Andrew Rybchenko
ev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads >> set by PMD >> >> On 11/7/19 9:56 AM, Matan Azrad wrote: >>> Hi >>> >>> From: Andrew Rybchenko >>>> On 11/6/19 9:58 AM, Matan Azrad wrote: >>&

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Matan Azrad
t;> Kollanukkaran ; Thomas Monjalon > >> > >> Cc: dev@dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to > >> offloads set by PMD > >> > >> On 11/7/19 9:56 AM, Matan Azrad wrote: > >>> Hi > >>>

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Andrew Rybchenko
n Nikhilesh Bhagavatula >>>> ; ferruh.yi...@intel.com; Jerin Jacob >>>> Kollanukkaran ; Thomas Monjalon >>>> >>>> Cc: dev@dpdk.org >>>> Subject: Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to >>>> offloads set by PMD

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-11-08 Thread Thomas Monjalon
08/11/2019 13:09, Andrew Rybchenko: > On 11/8/19 2:48 PM, Matan Azrad wrote: > > From: Andrew Rybchenko > >> It does 3 things for all port at the end of rte_eth_dev_configure() based > >> on > >> dev->data->dev_conf (if PMD updates it in the case of violations). > >> > >> 1. If requested offload i