[dpdk-dev] [PATCH v2] Fix `eventfd_link' module leakages and races

2015-03-23 Thread Pavel Boldin
Hi Thomas, There is by far more than 2 issues, but these are the only ones that appeared to us. The list of the issues that motivated the refactoring: 1. Only one error code for every fault (-EFAULT). 2. Copy-paste code from the `fget' function. 3. Ambiguous variable names. The `files'

[dpdk-dev] [PATCH v2] Fix `eventfd_link' module leakages and races

2015-03-23 Thread Thomas Monjalon
2015-03-23 13:36, Pavel Boldin: > Hi Thomas, > > There is by far more than 2 issues, but these are the only ones that > appeared to us. > > The list of the issues that motivated the refactoring: > >1. Only one error code for every fault (-EFAULT). >2. Copy-paste code from the `fget' func

[dpdk-dev] [PATCH v2] Fix `eventfd_link' module leakages and races

2015-03-23 Thread Thomas Monjalon
Hi Pavel, You forgot the Signed-off-by line. Huawei, Changchun, any comment on this patch? 2015-03-18 15:16, Pavel Boldin: > The `eventfd_link' module provides an API to "steal" fd from another > process had been written with a bug that leaks `struct file' because > of the extra reference counte

[dpdk-dev] [PATCH v2] Fix `eventfd_link' module leakages and races

2015-03-18 Thread Pavel Boldin
The `eventfd_link' module provides an API to "steal" fd from another process had been written with a bug that leaks `struct file' because of the extra reference counter increment and missing `fput' call. The other bug is using another process' `task_struct' without incrementing a reference counter