Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-12 Thread Trahe, Fiona
Hi Ayuj From: Ayuj Verma [mailto:ayve...@marvell.com] Sent: Friday, April 12, 2019 8:08 AM To: Trahe, Fiona ; akhil.go...@nxp.com; Kusztal, ArkadiuszX ; De Lara Guarch, Pablo Cc: Shally Verma ; Sunila Sahu ; Kanaka Durga Kotamarthy ; Arvind Desai ; dev@dpdk.org Subject: Re: [PATCH v2] app/tes

Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-12 Thread Ayuj Verma
Hi Fiona, Please see inline. Thanks and regards Ayuj Verma From: Trahe, Fiona Sent: 09 April 2019 20:47 To: Ayuj Verma; akhil.go...@nxp.com; Kusztal, ArkadiuszX; De Lara Guarch, Pablo Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev

Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-09 Thread Trahe, Fiona
Hi Ayuj, > -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Tuesday, April 9, 2019 12:34 PM > To: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > ; De Lara Guarch, Pablo > > Cc: shal...@marvell.com; ss...@marvell.com; kkotamar...@marvell.com; > ade

Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-09 Thread Bruce Richardson
On Tue, Apr 09, 2019 at 05:03:39PM +0530, Ayuj Verma wrote: > Return -ENOTSUP for unsupported tests > I disagree with this, since TEST_SKIPPED is the correct return value for unsupported test conditions IMHO. If part of the current infrastructure doesn't support that return value, I think the infr

[dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-09 Thread Ayuj Verma
Return -ENOTSUP for unsupported tests Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- app/test/test_cryptodev_asym.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index d2efce9..feed3a8