Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-07 Thread Stephen Hemminger
On Thu, 7 Jan 2021 15:59:59 + Ferruh Yigit wrote: > >> > >> int main(void) > >> { > >>pkt_burst_flow_gen(); > >>return 0; > >> } > > > > If I change your code like this to use union, Gcc 10 is still broken. > > This worked fine for me: https://godbolt.org/z/vdsxh9 I was looking

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-07 Thread Ferruh Yigit
On 1/7/2021 3:50 PM, Stephen Hemminger wrote: On Wed, 6 Jan 2021 23:39:39 -0600 George Prekas wrote: On 1/6/2021 12:02 PM, Ferruh Yigit wrote: On 12/5/2020 5:42 AM, George Prekas wrote: Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and the calculated IP checksum is wro

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-07 Thread Stephen Hemminger
On Wed, 6 Jan 2021 23:39:39 -0600 George Prekas wrote: > On 1/6/2021 12:02 PM, Ferruh Yigit wrote: > > On 12/5/2020 5:42 AM, George Prekas wrote: > >> Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c > >> and the calculated IP checksum is wrong on GCC 9 and GCC 10. > >> > >>

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-07 Thread Ferruh Yigit
On 1/7/2021 2:20 PM, George Prekas wrote: On 1/7/2021 5:32 AM, Ferruh Yigit wrote: On 1/7/2021 5:39 AM, George Prekas wrote: On 1/6/2021 12:02 PM, Ferruh Yigit wrote: On 12/5/2020 5:42 AM, George Prekas wrote: Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and the calcul

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-07 Thread Ferruh Yigit
On 1/7/2021 11:32 AM, Ferruh Yigit wrote: On 1/7/2021 5:39 AM, George Prekas wrote: On 1/6/2021 12:02 PM, Ferruh Yigit wrote: On 12/5/2020 5:42 AM, George Prekas wrote: Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and the calculated IP checksum is wrong on GCC 9 and G

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-07 Thread Ferruh Yigit
On 1/7/2021 5:39 AM, George Prekas wrote: On 1/6/2021 12:02 PM, Ferruh Yigit wrote: On 12/5/2020 5:42 AM, George Prekas wrote: Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and the calculated IP checksum is wrong on GCC 9 and GCC 10. Signed-off-by: George Prekas --- v

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-06 Thread Stephen Hemminger
On Wed, 6 Jan 2021 18:02:49 + Ferruh Yigit wrote: > On 12/5/2020 5:42 AM, George Prekas wrote: > > Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c > > and the calculated IP checksum is wrong on GCC 9 and GCC 10. > > > > Signed-off-by: George Prekas > > --- > > v2: > > *

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2021-01-06 Thread Ferruh Yigit
On 12/5/2020 5:42 AM, George Prekas wrote: Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and the calculated IP checksum is wrong on GCC 9 and GCC 10. Signed-off-by: George Prekas --- v2: * Instead of a compiler barrier, use a compiler flag. --- app/test-pmd/meson.build

[dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation

2020-12-05 Thread George Prekas
Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and the calculated IP checksum is wrong on GCC 9 and GCC 10. Signed-off-by: George Prekas --- v2: * Instead of a compiler barrier, use a compiler flag. --- app/test-pmd/meson.build | 1 + 1 file changed, 1 insertion(+) diff --