Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Olivier Matz
On Thu, Jul 29, 2021 at 10:31:45AM +, Gregory Etelson wrote: > Hello Olivier, > > [:snip:] > > > > > > Correct. Inner checksum is offloaded and outer computed in software. > > > > I think this approach is not sane: the value of the outer checksum depends > > on > > the inner checksum, so it

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Gregory Etelson
Hello Olivier, [:snip:] > > > > Correct. Inner checksum is offloaded and outer computed in software. > > I think this approach is not sane: the value of the outer checksum depends on > the inner checksum, so it has to be calculated after. There is a comment in > the > code about this: > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-29 Thread Olivier Matz
On Wed, Jul 28, 2021 at 04:07:51PM +, Gregory Etelson wrote: > Hello Oliver, > > Please see my comments below > > > On Tue, Jul 27, 2021 at 04:07:57PM +0300, Gregory Etelson wrote: > > > TX checksum of a tunnelled packet can be calculated for outer headers > > > only or for both outer and inn

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-28 Thread Gregory Etelson
Hello Oliver, Please see my comments below > On Tue, Jul 27, 2021 at 04:07:57PM +0300, Gregory Etelson wrote: > > TX checksum of a tunnelled packet can be calculated for outer headers > > only or for both outer and inner parts. The calculation method is > > determined by application. > > If TX ch

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-28 Thread Olivier Matz
Hi Gregory, Few comments below. On Tue, Jul 27, 2021 at 04:07:57PM +0300, Gregory Etelson wrote: > TX checksum of a tunnelled packet can be calculated for outer headers > only or for both outer and inner parts. The calculation method is > determined by application. > If TX checksum calculation ca

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-28 Thread Ajit Khaparde
On Tue, Jul 27, 2021 at 6:08 AM Gregory Etelson wrote: > > TX checksum of a tunnelled packet can be calculated for outer headers > only or for both outer and inner parts. The calculation method is > determined by application. > If TX checksum calculation can be offloaded, hardware ignores > existi

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-28 Thread Gregory Etelson
Hello, Please see below. Regards, Gregory > > Subject: [PATCH v2] app/testpmd: fix TX checksum calculation for > > tunnel > > > > TX checksum of a tunnelled packet can be calculated for outer headers > > only or for both outer and inner parts. The calculation method is > > determined by applicat

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-27 Thread Li, Xiaoyun
> -Original Message- > From: Gregory Etelson > Sent: Tuesday, July 27, 2021 21:08 > To: dev@dpdk.org > Cc: getel...@nvidia.com; Ajit Khaparde ; > Olivier Matz ; Andrew Rybchenko > ; Yigit, Ferruh ; > Thomas Monjalon ; sta...@dpdk.org; Li, Xiaoyun > > Subject: [PATCH v2] app/testpmd: fix T

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-27 Thread Li, Xiaoyun
Hi > -Original Message- > From: Gregory Etelson > Sent: Tuesday, July 27, 2021 21:08 > To: dev@dpdk.org > Cc: getel...@nvidia.com; Ajit Khaparde ; > Olivier Matz ; Andrew Rybchenko > ; Yigit, Ferruh ; > Thomas Monjalon ; sta...@dpdk.org; Li, Xiaoyun > > Subject: [PATCH v2] app/testpmd: f

[dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel

2021-07-27 Thread Gregory Etelson
TX checksum of a tunnelled packet can be calculated for outer headers only or for both outer and inner parts. The calculation method is determined by application. If TX checksum calculation can be offloaded, hardware ignores existing checksum value and replaces it with an updated result. If TX chec