[dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-08 Thread Juraj Linkeš
libjansson4 is not enough to build telemetry. Replace it with libjansson-dev. Signed-off-by: Juraj Linkeš --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fd4f79cfc..2d2292ff6 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,7 +

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-08 Thread Aaron Conole
Juraj Linkeš writes: > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. > > Signed-off-by: Juraj Linkeš > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-09 Thread David Marchand
Hello, On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš wrote: > > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. Thanks for the patch Juraj. Just a little comment, for the v2, there was no significant change and you could have kept Aaron and Ruifeng review tags. I

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-09 Thread Bruce Richardson
On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote: > Hello, > > On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš > wrote: > > > > libjansson4 is not enough to build telemetry. Replace it with > > libjansson-dev. > > Thanks for the patch Juraj. > Just a little comment, for the v2, there

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-09 Thread David Marchand
On Thu, Apr 9, 2020 at 11:24 AM Bruce Richardson wrote: > On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote: > > I just want others' opinion, since there is a work on removing the > > dependency on libjansson for telemetry. > > > That would be an end-goal but we are not fully there ye

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

2020-04-10 Thread David Marchand
On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš wrote: > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. Fixes: 99889bd85228 ("ci: introduce Travis builds for GitHub repositories") Cc: sta...@dpdk.org > Signed-off-by: Juraj Linkeš Acked-by: Aaron Conole Reviewed-by